misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

enhance(frontend): 共有と埋込みコード生成を親子メニューにまとめる #14702

Open kakkokari-gtyih opened 1 week ago

kakkokari-gtyih commented 1 week ago

What

ログイン中のノートメニューでは、ブラウザの共有ボタンと埋め込みコード生成ボタンを親メニュー内にまとめるように

Why

ノートメニューが縦に長くなってきているので整理したい(コピー系もまとめることを考えたけど使用頻度が高そうなので除外した)

Additional info (optional)

Checklist

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 19.42%. Comparing base (fa06c59) to head (5444ce7).

Files with missing lines Patch % Lines
packages/frontend/src/scripts/get-note-menu.ts 0.00% 43 Missing :warning:
packages/frontend/src/scripts/get-appear-note.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14702 +/- ## ============================================ - Coverage 39.67% 19.42% -20.26% ============================================ Files 1548 719 -829 Lines 194496 102083 -92413 Branches 2566 990 -1576 ============================================ - Hits 77174 19827 -57347 + Misses 116756 81707 -35049 + Partials 566 549 -17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 1 week ago

今までの 共有 は 共有→共有 になる?

kakkokari-gtyih commented 1 week ago

今までの 共有 は 共有→共有 になる?

今はそうなってるけど、もうちょっといい表現を探したいわね

syuilo commented 1 week ago

ほむん

kakkokari-gtyih commented 1 week ago

単純に親メニューの名前を 共有 / 埋め込み にするのでもいいかも

syuilo commented 1 week ago

ほむん