misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix(frontend): クライアント上での時間ベースの実績獲得動作が実績獲得後も発動している問題を修正 #14717

Closed kakkokari-gtyih closed 6 days ago

kakkokari-gtyih commented 6 days ago

What

実績獲得用のsetIntervalとかsetTimeoutが実績解除後は動かないように

Why

実績解除後は特に意味をなさない動作のため回避してパフォーマンス改善したい

Additional info (optional)

Checklist

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 19.59%. Comparing base (0d7d109) to head (b033d4e). Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/boot/main-boot.ts 0.00% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14717 +/- ## ============================================ - Coverage 41.29% 19.59% -21.71% ============================================ Files 1553 719 -834 Lines 200329 102161 -98168 Branches 3624 988 -2636 ============================================ - Hits 82735 20021 -62714 + Misses 117026 81593 -35433 + Partials 568 547 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 6 days ago

🙏🏿