misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

refactor(frontend): prefix css variables #14725

Closed syuilo closed 4 days ago

syuilo commented 5 days ago

What

Resolve #14620

Why

Additional info (optional)

Checklist

github-actions[bot] commented 5 days ago

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 26.93157% with 662 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (c14eba3) to head (0d29f11). Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/_common_/navbar.vue 0.00% 27 Missing :warning:
...es/frontend/src/components/MkSignupDialog.form.vue 0.00% 22 Missing :warning:
packages/frontend/src/ui/universal.vue 0.00% 18 Missing :warning:
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 17 Missing :warning:
packages/frontend/src/ui/deck/column.vue 0.00% 16 Missing :warning:
packages/frontend/src/ui/deck.vue 0.00% 13 Missing :warning:
packages/frontend/src/components/MkFolder.vue 0.00% 12 Missing :warning:
packages/frontend/src/components/MkRadio.vue 0.00% 10 Missing :warning:
packages/frontend/src/pages/admin-user.vue 0.00% 10 Missing :warning:
...ges/frontend/src/ui/_common_/navbar-for-mobile.vue 0.00% 10 Missing :warning:
... and 182 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14725 +/- ## =========================================== + Coverage 39.63% 39.66% +0.03% =========================================== Files 1553 1553 Lines 195043 195037 -6 Branches 3607 2574 -1033 =========================================== + Hits 77297 77368 +71 + Misses 117144 117101 -43 + Partials 602 568 -34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 5 days ago

レビュワーを募集しております

kakkokari-gtyih commented 5 days ago

--radiusとか--marginとかにはprefixつけない?

syuilo commented 5 days ago

テーマと関係ないものは付けてない

syuilo commented 5 days ago

別のprefixはつけて良さそう

syuilo commented 5 days ago

別のPRにする

syuilo commented 5 days ago

マージするぞ

syuilo commented 5 days ago

approveを募集しております

syuilo commented 4 days ago

🙏🏿