misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix(backend): キューのエラーログを簡略化するように #14748

Closed kakkokari-gtyih closed 2 days ago

kakkokari-gtyih commented 2 days ago

What

Details: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/649

Why

14625 を一部解決?

Additional info (optional)

Checklist

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 25.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (4c84842) to head (387296d). Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/backend/src/queue/QueueProcessorService.ts 25.00% 36 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14748 +/- ## =========================================== - Coverage 39.68% 39.66% -0.02% =========================================== Files 1553 1553 Lines 195038 195048 +10 Branches 3624 2523 -1101 =========================================== - Hits 77395 77366 -29 - Misses 117042 117114 +72 + Partials 601 568 -33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 days ago

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

syuilo commented 2 days ago

あんまり意図が分かってないわね スタックトレースあれば原因の調査に役立ちそうな気がする

anatawa12 commented 2 days ago

UnrecoverableErrorは原則手動でthrowしないと発生しないからログの場所はメッセージにあるはずなので十分ということではないでしょうか。また、発生原因も比較的固定だということだと思います。

(UnrecoverableErrorに詳しくないので間違ってたらごめんなさい)

syuilo commented 2 days ago

ほむん

syuilo commented 2 days ago

🙏🏿

anatawa12 commented 2 days ago

https://github.com/search?q=repo%3Amisskey-dev%2Fmisskey%20UnrecoverableError&type=code を眺めた感じエラーではあるけど FATAL ではなく大域 return 的な使われ方してる面はありそう(それが想定されてるってことなんかな)