misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
10.09k stars 1.38k forks source link

refactor(backend): SystemWebhookで送信されるペイロードの型を追加 #14980

Closed samunohito closed 3 days ago

samunohito commented 5 days ago

What

タイトルの通りです。

Why

fix #14979

Additional info (optional)

Checklist

github-actions[bot] commented 5 days ago

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 79.36508% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.98%. Comparing base (eef0c89) to head (f10a781). Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/WebhookTestService.ts 61.11% 7 Missing :warning:
...backend/src/core/AbuseReportNotificationService.ts 0.00% 3 Missing :warning:
packages/backend/src/core/QueueService.ts 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14980 +/- ## =========================================== - Coverage 41.67% 39.98% -1.70% =========================================== Files 1565 1561 -4 Lines 203008 197290 -5718 Branches 3678 3608 -70 =========================================== - Hits 84596 78878 -5718 Misses 117840 117840 Partials 572 572 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

kakkokari-gtyih commented 5 days ago

(Off-topic) misskey-jsにWebhookの型を露出させるようにしたらJavaScript/TypeScriptで連携アプリをつくる人に恩恵がありそう

syuilo commented 3 days ago

🙏