misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
10.1k stars 1.38k forks source link

fix(backend): Inboxのエラーをthrowせずreturnしている問題を修正 #15022

Closed kakkokari-gtyih closed 3 days ago

kakkokari-gtyih commented 3 days ago

What

Fixes a type confusion bug where exceptions are incorrectly returned instead of thrown. The calling code will attempt to process the Error as an Activity, causing it to fail with cryptic and confusing errors.

Why

Fix https://activitypub.software/TransFem-org/Sharkey/-/issues/796 エラーがエラーとしてログに残るようになる

Additional info (optional)

Checklist

github-actions[bot] commented 3 days ago

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 39.86%. Comparing base (c1f19fa) to head (d7e7b9a). Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/core/activitypub/ApInboxService.ts 11.11% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #15022 +/- ## =========================================== - Coverage 39.98% 39.86% -0.12% =========================================== Files 1563 1563 Lines 197737 197741 +4 Branches 3644 3633 -11 =========================================== - Hits 79056 78835 -221 - Misses 118077 118299 +222 - Partials 604 607 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

syuilo commented 3 days ago

🙏