search

misskey-dev / misskey

๐ŸŒŽ A completely free and open interplanetary microblogging platform ๐Ÿš€
https://misskey-hub.net/
GNU Affero General Public License v3.0
10.07k stars 1.38k forks source link

Incorrect birthday #5375

Open fz0000 opened 5 years ago

fz0000 commented 5 years ago

๐Ÿ’ก Summary

Incorrect birthday can be set (updated successfully dialog pops up but not actually saved)

๐Ÿ™‚ Expected Behavior

โŒๆ“ไฝœใ‚’ๅฎŒไบ†ใงใใพใ›ใ‚“

โ˜น๏ธ Actual Behavior

โœ”ใƒ—ใƒญใƒ•ใ‚ฃใƒผใƒซใ‚’ไฟๅญ˜ใ—ใพใ—ใŸ

๐Ÿ“ Steps to Reproduce

date

๐Ÿ“Œ Environment

ver 11.30.0

fz0000 commented 5 years ago

By the wayโ€ฆโ€ฆ Born in the future is allowed? ๐Ÿคฃ e.g.

future
SanMurakami commented 5 years ago

This is a kind of humor and I think don't need to fix it.

fz0000 commented 5 years ago

It seems to bring some other problems... Are these issues or by design? ๐Ÿค” And should we open new issues or just track them here?

  1. If the date is not set before, the indicator will not display when I input an invalid date with the day not inputted in the last. (e.g. input in the following order: year-> day-> month) day

  2. The indicator text language is OS based(i.e. If I use Win10 ENU and set the set language to Japanese in the misskey settings, the indicator is still English.

  3. The indicator text seems to be different on different browsers. image

u1-liquid commented 5 years ago

The second and third items are design in my implementation. as you see, the indicator texts are depends on your browser; It doesn't matter what your OS default language is, these texts are from your browser, so If you install firefox with ja-JP locale #, it will show the messages in japanese.

I think that first (year>day>month) one is some kind of issue in browser JS side (I don't have idea how we can workaround this).

subpub commented 4 years ago

My browser locale is in English, still the date in the profile page shows in japanese