misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
10.04k stars 1.37k forks source link

脱FontAwesome #6511

Closed syuilo closed 1 year ago

syuilo commented 4 years ago

Summary

Simirall commented 4 years ago

Material iconsとか https://material.io/resources/icons/

Our icons are free for everyone to use. Available under Apache license version 2.0.

EbiseLutica commented 4 years ago

以前使ってみたことあるけど、Material Icons のほうが語彙が少なかった

Simirall commented 4 years ago

Syuilo Icon Font🧐

syuilo commented 3 years ago

これとか https://fonts.google.com/icons

rinsuki commented 3 years ago

それ中身 Material Icons だよ

syuilo commented 3 years ago

おっと失礼

kazukyakayashi commented 3 years ago

Why not https://forkaweso.me/ (License: SIL OFL 1.1, Open Font License) ?

Or :

acid-chicken commented 3 years ago

あと重め

これってアイコンのレンダリング負荷の話?あるいはレンダリングのみに限らないライブラリの動作コストとか、アセットサイズのことを指している?

tamaina commented 3 years ago

アセットサイズ

Tree Shakingしてるしほかのライブラリにしたとしても減るかしら?

syuilo commented 3 years ago

あと重め

これってアイコンのレンダリング負荷の話?あるいはレンダリングのみに限らないライブラリの動作コストとか、アセットサイズのことを指している?

どっちもかな ひとつひとつがVueのコンポートになっているから多少なりともレンダリングコストが発生するし、バグか知らんけどTreeShakingとかCodeSplittingが何故か効かない(DynamicImportでしか読み込まれないファイル内であるアイコンをImportしていても、アイコンだけ何故かメインのバンドルに含まれる)

syuilo commented 3 years ago

後これは気持ちの問題だけどできれば完全にオープンソースなもの使いたい

syuilo commented 3 years ago

https://css.gg/app もある

syuilo commented 3 years ago

MaterialIcons使う方向で進めている

syuilo commented 2 years ago

やっぱり https://github.com/tabler/tabler-icons が良さそう

syuilo commented 2 years ago

やっていくか

ThatOneCalculator commented 2 years ago

Thoughts on https://phosphoricons.com/ ? (+ https://github.com/phosphor-icons/phosphor-vue)

syuilo commented 2 years ago

Thoughts on https://phosphoricons.com/ ? (+ https://github.com/phosphor-icons/phosphor-vue)

cool

Johann150 commented 2 years ago

I think an issue we should also consider is that it will be confusing if the look of the icons changes. In some places this might be okay because there is also text next to the icon, but in some places (e.g. Top Menu in Classic UI) there is just the icon.

I am not sure if it is really necessary (and also worth the big effort) to switch icon sets.

ThatOneCalculator commented 2 years ago

Phosphor has (almost) all the icons that Misskey currently uses, so I don't think it's too big of an issue

Johann150 commented 2 years ago

My concern is more that the icons will just look different not whether the icon set has icons with the same name.

Take for example the "follow requests" button. It currently looks like this: icon of user with a clock I'm not sure what Phosphor icon you would want to replace it with, because I could not find a similar icon. Maybe user-circle-gear?

person in a circle with gear

But as you can see, the icons are quite different. If I am looking in my menu bar and looking for a specific icon because I know what it used to look like, I will be confused because I can not find it.

ThatOneCalculator commented 2 years ago

I'm not sure what Phosphor icon you would want to replace it with, because I could not find a similar icon. Maybe user-circle-gear?

More likely user-gear or user-list, but I get where you're coming from. I still think it's a good idea to switch away from FA, but maybe polling the community about some ideas would be good

image

syuilo commented 2 years ago

I prefer tabler icons for the way the corners are represented. image

syuilo commented 2 years ago

My concern is more that the icons will just look different not whether the icon set has icons with the same name.

Conversely, there are cases where Fontawesome does not have appropriate icons, but Tabler/Phosphor icons do. (e.g. icon for webhook)