misskey-dev / misskey

๐ŸŒŽ A completely free and open interplanetary microblogging platform ๐Ÿš€
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.99k stars 1.36k forks source link

Follows/Followers Visibility changes won't be saved unless clicking on an other checkbox #8130

Closed rakino closed 2 years ago

rakino commented 2 years ago

๐Ÿ’ก Summary

Follows/Followers Visibility changes won't be saved unless I clicking on an other checkbox.

๐Ÿ™‚ Expected Behavior

Changes should be saved when I modifying Follows/Followers Visibility in Privacy Settings.

โ˜น๏ธ Actual Behavior

It seems that the saving operation will only be executed when I clicking on a checkbox. So in the case I just change the visibility, that change won't be saved.

๐Ÿ“ Steps to Reproduce

  1. Navigate to Settings -> Privacy, find Follows/Followers Visibility
  2. Change the visibility only
  3. Navigate to anywhere else and then back to step 1.

๐Ÿ“Œ Environment

4ioskd commented 2 years ago

This issue isn't solved. Same behavior is occured in latest misskey 12.103.1

Johann150 commented 2 years ago

@update:modelValue="save()" needs to be added to ffVisibility setting in packages/client/src/pages/settings/privacy.vue

tamaina commented 2 years ago

:(bind)ใ‚’v-model:ใซใ—ใชใ‹ใฃใŸโ€ฆใจใ„ใ†ใ‚ใ‘ใงใ‚‚ใชใ•ใใ†๏ผŸ

tamaina commented 2 years ago

(v-modelใฎ็œ็•ฅ่จ˜ๅทใฃใฆใ‚ใฃใŸใฃใ‘

Johann150 commented 2 years ago

:(bind)ใ‚’v-model:ใซใ—ใชใ‹ใฃใŸโ€ฆใจใ„ใ†ใ‚ใ‘ใงใ‚‚ใชใ•ใใ†๏ผŸ

v-model is used, but if I understand correctly the issue is that the values are saved in the client, but they also have to be saved on the server using the API in the save function.

(v-modelใฎ็œ็•ฅ่จ˜ๅทใฃใฆใ‚ใฃใŸใฃใ‘

I think not https://v3.vuejs.org/guide/migration/v-model.html#v-model-arguments

Johann150 commented 2 years ago

I wonder if there could be @update on the _formRoot element to catch all the different update events? That would not be a good idea because that would also call the save function also for properties that can not be saved via the API, causing unnecessary network congestion and/or server load.