search

misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.99k stars 1.36k forks source link

Clip page has default favicon #8265

Closed ThatOneCalculator closed 2 years ago

ThatOneCalculator commented 2 years ago

💡 Summary

instance.tld/clips/whatever shows the default Misskey favicon, not the set one.

(See screenshot of https://stop.voring.me/clips/8wgtnk4aps vs https://stop.voring.me/) Screenshot_2022-02-07-02-39-26_2560x1440

🥰 Expected Behavior

Tab has instance favicon

🤬 Actual Behavior

Tab has default favicon

📌 Environment

Misskey version: 12.103.1 (development) Your OS: Linux Your browser: Firefox

Johann150 commented 2 years ago

The issue seems to be that some templates are missing the icon variable when rendering the pug templates. These should be specified like this https://github.com/misskey-dev/misskey/blob/b267a504ca4563e042929198319273e969939fc9/packages/backend/src/server/web/index.ts#L330

I think this would not only be the case for clip pages, but I think the icon was also missing for other pages.

ThatOneCalculator commented 2 years ago

Fixed by #8270

Johann150 commented 2 years ago

Normally the issue is closed when the PR is merged, so you don't have to close it manually. 👍

ThatOneCalculator commented 2 years ago

Normally the issue is closed when the PR is merged, so you don't have to close it manually. +1

Ah gotcha! My bad.

robflop commented 2 years ago

Specifically, for a PR to close an issue it has to contain "closes \<issue>" or "fixes \<issue>" in the body and get merged, afaik.