misskey-dev / misskey

๐ŸŒŽ An interplanetary microblogging platform ๐Ÿš€
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.7k stars 1.29k forks source link

[Minor] Bottom bar looks odd on iPhones with rounded borders (iPhones X, 11-13) #8311

Open NovaAndrom3da opened 2 years ago

NovaAndrom3da commented 2 years ago

Summary

The current bottom padding amount looks odd on the iPhone X, 11, 12, and 13. This is not a major issue.

syuilo commented 2 years ago

Can someone provide a screenshot?

NovaAndrom3da commented 2 years ago

@syuilo Sadly iOS screenshots do not show the screen border radius so it yields the same screenshot a device with a rectangular screen would provide. I can take a picture of my phone separately though.

Also, the emoji picker (both the one for a reaction and for when composing a note) are too cut off by the border radius.

rinsuki commented 2 years ago

@Froggo8311 do you mean like this?

imageimageimage

syuilo commented 2 years ago

ใ‚ปใƒผใƒ•ใ‚จใƒชใ‚ข่€ƒๆ…ฎใ—ใŸCSSๆ›ธใ„ใฆใ‚‹ใ‹ใ‚‰โ†‘ใฎใ‚ˆใ†ใซใฏใชใ‚‰ใชใ„ใฏใšใชใ‚“ใ ใ‘ใฉใช (ใŸใ ๅฎŸๆฉŸใงๅ‹•ไฝœ็ขบ่ชใ—ใŸใ“ใจใฏ็„กใ—)

syuilo commented 2 years ago

(Misskeyใฎใƒใƒผใ‚ธใƒงใƒณใŒๅคใ„ใจใ‹ใ‹ใ—ใ‚‰)

rinsuki commented 2 years ago

misskey.io ใฃใฆๅคใ„ใ‚“ใ ใฃใ‘ใ€ๆœ€ๆ–ฐใฎใ‚„ใค่ตฐใฃใฆใ‚‹ใจใ“ใ‚ใ‚‹๏ผŸ

syuilo commented 2 years ago

https://sushi.ski/ ใŒๆœ€ๆ–ฐใ‹ใค่ชฐใงใ‚‚็™ป้Œฒใงใใ‚‹

rinsuki commented 2 years ago

sushi.skiใ ใจใ“ใ‚“ใชๆ„Ÿใ˜ (ใ‚ใ‚“ใพๅค‰ใ‚ใ‚“ใชใ„ๆฐ—ใŒใ™ใ‚‹) imageimage

syuilo commented 2 years ago

ใ‚ใƒผๅ‹•ใ„ใฆใชใ•ใใ† ใ‚ใ‚ŠใŒใจใ†๐Ÿ™

syuilo commented 2 years ago

ใ‚ปใƒผใƒ•ใ‚จใƒชใ‚ข่€ƒๆ…ฎใ—ใŸCSSๆ›ธใ„ใฆใ‚‹็ฎ‡ๆ‰€ใฏ https://github.com/misskey-dev/misskey/issues/8311#issuecomment-1036996457 ใฎไธ‰ๆžš็›ฎใฎUIใ ใ‘ใ ใฃใŸ

rinsuki commented 2 years ago

ใใ‚Œใ‚‚็ตๅฑ€ใ ใ‚ใใ†

image
syuilo commented 2 years ago

ใ‚ใ‚Œใƒผ ใ“ใ†ใ„ใ†ๆ›ธใๆ–นใ˜ใ‚ƒๅŠนใ‹ใชใ„ใฎใ‹ใ—ใ‚‰ https://github.com/misskey-dev/misskey/blob/64f4231283bfe6bb6b2a56e60a0b7fd99027cdbe/packages/client/src/components/ui/menu.vue#L254

rinsuki commented 2 years ago

https://developer.mozilla.org/ja/docs/Web/CSS/env()

ใƒ–ใƒฉใ‚ฆใ‚ถใƒผใซ็”ป้ขไธŠใฎๅˆฉ็”จๅฏ่ƒฝใช็ฏ„ๅ›ฒๅ…จไฝ“ใ‚’ไฝฟ็”จใ™ใ‚‹ใ‚ˆใ†ใซๆŒ‡็คบใ—ใ€ env() ๅค‰ๆ•ฐใ‚’ไฝฟ็”จใงใใ‚‹ใ‚ˆใ†ใซใ™ใ‚‹ใซใฏใ€ๆ–ฐใ—ใ„ใƒ“ใƒฅใƒผใƒใƒผใƒˆใฎใƒกใ‚ฟๅ€คใ‚’่ฟฝๅŠ ใ™ใ‚‹ๅฟ…่ฆใŒใ‚ใ‚Šใพใ™ใ€‚

ใ“ใ‚Œใ‹ใช

rinsuki commented 2 years ago

โ†‘ใ“ใ‚Œ่ฟฝๅŠ ใ—ใŸใ‚‰ใพใ‚ใพใ‚ใชๆ„Ÿใ˜ใซใชใฃใŸ

image
NovaAndrom3da commented 2 years ago

The new tab bar position looks better, but the emoji picker is still very close to the screen border. F7D182A0-B700-458B-A21F-119D12C7752A

NovaAndrom3da commented 2 years ago

The settings > privacy screen now isnt long enough so the "keep content warnings" checkbox is unaccessible