search

misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.99k stars 1.36k forks source link

Image thumbnail retains after switching between dark/light mode #8831

Open nvisser opened 2 years ago

nvisser commented 2 years ago

💡 Summary

When you open an image from the timeline, then switch between dark/light mode with the D hotkey, the thumbnail in the timeline retains. See also https://borg.social/files/43462ea6-ff92-4d95-aac8-71a6f854d462

🥰 Expected Behavior

The thumbnail stays in its own note.

🤬 Actual Behavior

The image thumbnail retains in the place where the note was. Upon scrolling, it stays in its note, but a copy floats on the timeline. div.pswp__container is not hidden/destroyed correctly?

📝 Steps to Reproduce

  1. Click an image in the timeline
  2. Toggle between dark/light mode repeatedly by pressing D
  3. Click outside the image to go back to the timeline.
  4. Scroll.

📌 Environment

Misskey version: 12.111.0 Your OS: Gentoo GNU+Linux Your browser: Firefox 101.0.1

Johann150 commented 2 years ago

I assume that Photoswipe has a different binding for the d hotkey.