regression: some API endpoints now requires an empty JSON object as the parameter

[saschanaz]

💡 Summary

Some endpoints don't have a required parameter but still asks an object as a POST body

🥰 Expected Behavior

Don't ask the body

🤬 Actual Behavior

It does

📝 Steps to Reproduce

1. curl -X POST https://misskey.io/api/meta
2. curl -X POST https://p1.a9z.dev/api/meta
3. curl -X POST -H "Content-Type: application/json" -d "{}" https://p1.a9z.dev/api/meta

1 and 3 succeeds, 2 fails.

📌 Environment

Misskey version: 12.x vs 13.x Your OS: Windows 11 Your browser: Firefox

[saschanaz]

See also: #9355

[tamaina]

curl -X POST -H "Content-Type: application/json" https://p1.a9z.dev/api/metaは {"statusCode":400,"code":"FST_ERR_CTP_EMPTY_JSON_BODY","error":"Bad Request","message":"Body cannot be empty when content-type is set to 'application/json'"} なんだけど規格とはいえちょっと厳しいところではある

[saschanaz]

Probably because b75184ec8e3436200bacdcd832e3324702553d20 added validate() on endpoint-base.ts and each meta indeed requires an object:

https://github.com/misskey-dev/misskey/blob/52cbe07a780c0542912798e1e9bc1b78a63d6806/packages/backend/src/server/api/endpoint-base.ts#L48

https://github.com/misskey-dev/misskey/blob/f1fd1d2585bd5230caea4c7b8814c2cf007e57cc/packages/backend/src/server/api/endpoints/meta.ts#L309-L315

[saschanaz]

それと、こういうAPIはGETにも対応する方がユーザーとしては楽だと思います