search

misson20000 / exefs_patches

ExeFS patches for Nintendo Switch sysmodules, intended to be loaded by Atmosphère-loader
121 stars 17 forks source link

nifm ctest patches cause nifm to rampage #30

Open masagrator opened 1 year ago

masagrator commented 1 year ago

Which patch is broken? nifm ctest

Describe the bug This patch is causing probably nifm to use whole Core 3 when connected to Wi-Fi. It's not always the case (it seems this also depends on hosts file what servers are blocked and when it tries to connect to blocked server), but it's easier to reproduce this issue by connecting to network without internet connection.

To Reproduce Steps to reproduce the behavior:

  1. Apply nifm ctest patches on boot
  2. Connect to Wi-Fi without internet connection
  3. Check CPU usage, for example with Status Monitor Overlay (though expect that overlay will stop responding and eventually crash system)

Expected behavior Core 3 Usage at 100%

Screenshots 208228225-4ededf23-d84e-4f1d-88f7-12cbc410c6a6

@HookedBehemoth is aware of this issue and couldn't fix it. What I'm asking is to add warning to README about potential consequences of using those patches.

HookedBehemoth commented 1 year ago

I think back then I recommended adding a sleep into the patch. Ever looked into that? We have enough space since it's the start of a big function.

masagrator commented 1 year ago

I didn't. I'm not interested into those patches, but because some people started including them with AiOs I'm getting more reports about status monitor crashing. It seems somebody else is making up-to-date ctest patches, but couldn't find who was making them.

I was forced to add info about this and solution to readme of my repo.