missreyes / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

grouping of elements #4

Open rimmesbe opened 7 years ago

rimmesbe commented 7 years ago

Interesting technique here to separate the images and text into rows. I think it would be a lot more efficient to wrap the image and title text together as a component. You may have to change the display of the image to block to get that desired effect, but it will be easier to expand later on if we want to add more images.

https://github.com/missreyes/prj-rev-bwfs-tea-cozy/blob/master/teacozy/index.html#L35-L44

missreyes commented 7 years ago

Would that be like this: <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-4/img-berryblitz.jpg" <h4 class="titles">Fall Berry Blitz Tea</h4>alt="Berry Blitz">

or like this: <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-4/img-spiced-rum.jpg" alt="Spiced Rum"><h4 class="titles">Spiced Rum</h4>

rimmesbe commented 7 years ago

your html got converted into markup. Wrap code in

On Tue, Aug 1, 2017 at 3:25 PM, missreyes notifications@github.com wrote:

Would that be like this: <img src="https://s3.amazonaws.com/codecademy-content/courses/ freelance-1/unit-4/img-berryblitz.jpg" Fall Berry Blitz Teaalt="Berry Blitz">

or like this: [image: Spiced Rum] https://camo.githubusercontent.com/57984c702477efd386032bd169c769b9796201a9/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f636f6465636164656d792d636f6e74656e742f636f75727365732f667265656c616e63652d312f756e69742d342f696d672d7370696365642d72756d2e6a7067 Spiced Rum

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/missreyes/prj-rev-bwfs-tea-cozy/issues/4#issuecomment-319471302, or mute the thread https://github.com/notifications/unsubscribe-auth/AJfw_ANsQJaxYZuYbd9F-e2bkyfKSZ4gks5sT3u3gaJpZM4OqHWR .

missreyes commented 7 years ago

Ok edited it. Alway wondered what that mark was used for under the ~!