search

missreyes / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

footer is a div #5

Closed rimmesbe closed 7 years ago

rimmesbe commented 7 years ago

A footer tag is just a div with a fancy name. Same with header, nav, main, article, section etc. No need for and extra div around it. In general I'm seeing a lot of divs with no classes or id's which is a red flag. Generally a div with no attribute means either it's an unnecessary div or the selector being used is not optimal. Better to target a class than a chain: .div-class { } is better than .parent-class div { }

missreyes commented 7 years ago

I tried it without on the footer but I couldn't get it to work correctly.

missreyes commented 7 years ago

Removed <div>'s & added "align-items: center;" to CSS and it worked.