search

mister-benjamin / etherwake-nfqueue-openwrt

OpenWrt package feed for etherwake-nfqueue
6 stars 1 forks source link

Update openwrt version to reflect changes in etherwake-nfqueue #1

Closed 7ritn closed 7 months ago

7ritn commented 7 months ago

This PR updates the OpenWRT repository of etherwake-nfqueue to the current version of etherwake-nfqueue

mister-benjamin commented 7 months ago

Could you squash the commits?

7ritn commented 7 months ago

Please squash and merge, so commit history is kept :)

mister-benjamin commented 7 months ago

Done. Thanks.

Will you open a pull request in https://github.com/openwrt/packages, or do you want me to do it?

7ritn commented 7 months ago

Sure I can do that, however I'm somewhat confused since the Makefile here and in the packages repository have different dependencies (+iptables-mod-nfqueue) vs (+nftables +kmod-nft-queue). Was this repository simply not updated to reflect the changes?

Plus I think I also need to add the libmnl as a dependecy since the project now depends on it, right?

mister-benjamin commented 7 months ago

I will take a look later today.

mister-benjamin commented 7 months ago

@7ritn Sorry for the delay. The dependencies of the OpenWrt package were updated with https://github.com/openwrt/packages/commit/5e894cae13d2b6956412f7dd7da36fba752a55c1, because OpenWrt switched from iptables to nft some time ago. The iptables dependency was listed only because of how the rules were configured in user space, and the corresponding kernel module package is now kmod-nft-queue. If you would like to update the package in OpenWrt, I suggest you build and test it with the dependencies currently listed upstream, and open a pull request. Unfortunately I currently don't have the time to do this myself.