search

misterhay / VISCA-IP-Controller

Python code for controlling PTZ cameras using VISCA commands over IP
The Unlicense
82 stars 28 forks source link

Pull in changes from Yook74's fork #2

Closed misterhay closed 2 years ago

misterhay commented 2 years ago

Let's start looking at how to incorporate these back in.

Yook74 commented 2 years ago

So one of the key design decisions I made was to separate this into a generic camera driver which could be used for any application and application code. My application code lives in another repo actually.

If we're going to publish this as a PyPI package, I'd recommend publishing just the generic driver, although I could see arguments for publishing it as an application too.

Yook74 commented 2 years ago

I haven't looked at your application code recently and I don't think much of it will be directly compatible with my Camera class. Hopefully it won't take much work to make it compatible though. Let me know how you'd like to divide labor on that effort (assuming that's the direction you'd like to go)

misterhay commented 2 years ago

I like your idea of separating the camera class, that's similar to what I've started with camera.py. I really like what you've done with blocking, retries, and response receipt attempts. It might be most efficient for us to add a few functions to the Camera class in your repo for submission to PyPI, and then convert this repo to just a GUI application that uses that class. Thoughts?

Yook74 commented 2 years ago

I'd be happy to add methods to my Camera class. Let me know what you'd like to add.

I'm fine with having the application and library code both on this repo in different directories or splitting them out into different repos. We will need some sort of home for the library code even if we publish it to PyPI though, so making this repo only application code without creating a new repo for the library code won't fly.