Focus far and focus near reversed for speed parameter of manual_focus()

misterhay / VISCA-IP-Controller

Python code for controlling PTZ cameras using VISCA commands over IP

The Unlicense

81 stars 29 forks source link

Focus far and focus near reversed for speed parameter of manual_focus() #23

Closed balongi2 closed 1 month ago

balongi2 commented 8 months ago

The speed parameter of manual_focus() says:

:param speed: -7 to 7 where positive integers focus near and negative integers focus far

However, positive integers (near) use direction_hex == '2' and negative numbers (far) use direction_hex == '3', which is odds with the VISCA spec.

Far(Standard) | 8x 01 04 08 02 FF Near(Standard) | 8x 01 04 08 03 FF

(Thanks for this useful module!)

misterhay commented 8 months ago

Great catch, thank you. PR created.