search

misterhay / VISCA-IP-Controller

Python code for controlling PTZ cameras using VISCA commands over IP
The Unlicense
82 stars 28 forks source link

16 Camera Memory Slot Limit? #26

Closed dhtseany closed 1 week ago

dhtseany commented 1 week ago

Hi, why was the script limited to 16 camera memory slots?

The AIDA PTZ20 supports 127 memory slots but when I attempt to call on a value past 15 I get the following error:

File "/usr/lib/python3.12/site-packages/visca_over_ip/camera.py", line 615, in recall_preset raise ValueError('Preset num must be 0-15 inclusive') ValueError: Preset num must be 0-15 inclusive

misterhay commented 1 week ago

It looks like according to the documentation you are right. And making that change likely won't break things for other cameras, other than not getting the right error message if they call a value outside of the range of their camera. Will fix.

misterhay commented 1 week ago

Fixed

dhtseany commented 6 days ago

Perfect, I appreciate your assistance, would you mind giving the release a version bump so I can get it updated on the AUR? Thanks!

misterhay commented 5 days ago

Done :) v0.5.0