search

misterpeddy / hands-down

Slow the spread of COVID-19 by discouraging people from touching their face
6 stars 1 forks source link

Fixes the GHP action mistake + improvements #58

Closed Berkmann18 closed 4 years ago

Berkmann18 commented 4 years ago

Namely due to me forgetting one keyword that laid to https://github.com/misterpeddy/hands-down/runs/622189635 failing :disappointed:.

Performance changes (on /): Perf master build change
FCP 0.7s 0.8s +0.1
SI 0.7s 0.8s +0.1
TTI 5.5s 5.3s -0.2
FMP 0.7s 0.8s +0.1
FCI 5.4s 4.9s -0.6
MPFID 200ms 260ms -5,390
----------- -------------- ------------- -----------
Network payload 680 KB 674 KB -6
JS exec. time 0.2s 0.3s +0.1
Main-thread work 1.0s 1.1s +0.1
Static assets 7 7 0

Checklist (things to achieve):

More can be found on https://github.com/thedaviddias/Front-End-Performance-Checklist

This PR also contains @amirhmk's changes which make use of the Page Visibility API.

Berkmann18 commented 4 years ago

@amirhmk Do you think it would be worth merging skeleton.css with style.css so that once the build step finished, there are fewer stylesheets and no CSS rule override?

Berkmann18 commented 4 years ago

The LHCI changes are as follows:

/ Name Perf A11y BP SEO PWA Average
master 86% 100% 79% 100% (33.33%, 33.33%, 85.71%) 73.91%
pr -1% - - - (-, -, -) -0.14%
potential +1% - - - (-, -, -) +0.14%
/dev Name Perf A11y BP SEO PWA Average
master 88% 92% 79% 100% (33.33%, 33.33%, 85.71%) 73.05%
pr -7% +8% - - (-, -, -) +0.15%
potential - +8% - - (-, -, -) +1.15%
others Name Perf A11y BP SEO PWA Average
master 100% 100% 86% 100% (33.33%, 33.33%, 85.71%) 76.91%
pr - - - - (-, -, -) -
potential - - - - (-, -, -) -

Note: