Viewtype Rework - Githubissues

bartolomesoriano commented 7 years ago

From @mistervee on May 6, 2017 1:9

Just some info on this;

All view type xml's have been renamed to include the id of the viewtype
All views and includes have been commented out apart from view 50
View settings will be specific to the view and xml. For example the topbar can be turned on or off and will only apply to the viewtype and xml (like myvideo nav and mymusicnav).
The main xml will only contain very little code. Just the view include and mediamenu. See mygames.xml for an example
Any new panels that can be reused should be in Includes_common with param includes. Example include is Panel_Background_Default
Specific things only for views that can be reused should be in Includes_views using param includes for dimension visibility ect. Discart/Fake Disc/Handwriting is an example not yet coded.
List view is still a WIP
Info soon but i have updated a debug grid and keyboard.xml to help. This will give you an idea on where to position screen elements for consistency. And provide container.content and listitem.DBTYPE to make it easier for working out visibility conditions.
Trying to make the variables common to all view types (cuts down on variables maintenance of code) -- for textures poster, landscape, fanart ect. 1 variable for each should be OK and can be reused in each view, so 1 variable for each art type -- for labels same as previous they need to be reusable to cut down on variables. for example ViewLabelTitleVar, ViewLabelSubtitleVar, ViewLabel1Var, ViewLabel2 Var ect (All this is near the top of the variable.xml with commented headings) -- Mediaflags should be common too (param includes required) nothing done though will require some thought and may have to do a spreadsheet on how this will work. Still not 100% on how this will work out
I really need to finish the list view to make sure this will all work as i hope as visibility conditions could get quite complex.

View types will apply to (not sure if i have missed any);

Myvideonav
Mymusicnav
Addonbrowser
Mypics
Myprograms
My Games (new in leia)

Copied from original issue: mistervee/skin.madnox.backup#13

bartolomesoriano commented 7 years ago

From @mistervee on May 6, 2017 1:10

@MadMikeDoc @bartolomesoriano Some info

Also was thinking text discussion on Skype might be helpful. For Q&A and sharing ideas to make things easier moving forward.

bartolomesoriano commented 7 years ago

@mistervee thanks! Would views apply to weather and PVR also? Looking forward to the debug aids. Count me in for Skype discussion, I am in the Dominican Republic, which is on USA Eastern Standard Time. Just let me know when you would like to have a chat.

bartolomesoriano commented 7 years ago

From @MadMikeDoc on May 10, 2017 12:36

@mistervee , sorry on delay getting back, don't use skype much but can set it up if it helps us. I'm UK based so our team are Uk, Germany, Dominican Republic and I believe you are in Australia Mr. V? So using it could be interesting?

bartolomesoriano commented 7 years ago

From @mistervee on May 14, 2017 5:36

@MadMikeDoc @bartolomesoriano @meowmoo

Timing may be hard. (my pc is always on so i may or may not be around). Even if we don't get in all at once it will be good for Q&A and discussion.

My skype name is; Mr V

I have set my profile picture to the madnox logo so hopefully i shouldn't be to hard to find.

Feel free to send me a contact request.

bartolomesoriano commented 7 years ago

From @mistervee on May 14, 2017 7:24

@bartolomesoriano @MadMikeDoc @meowmoo

Add this to your keymap.xml will be heaps of help F5 - self explanatory F6 - In built kodi debugging - will tell you what xml is displayed F7 - ListItem.DBTYPE and Conatiner.Content (great for working on view types and visibility conditions) F8 - A overlay texture to help align textures, labels ect to be consistent with other views(not for dialogs) (try it in myweather.xml, skin settings, and list view and you will understand)

The debuginfo xml and grid texture are in latest git.

<keymap>
    <global>
        <keyboard>
            <F5>XBMC.ReloadSkin()</F5>
            <F6>Skin.ToggleDebug</F6>
            <F7>Skin.ToggleSetting(DebugInfo)</F7>
            <F8>Skin.ToggleSetting(DebugGrid)</F8>          
        </keyboard>
    </global>
</keymap>

bartolomesoriano commented 7 years ago

Thanks @mistervee , this is really helpful!

However, I can't get F7 or F8 to work. I couldn't find any reference in the xmls to the skin setting DebugInfo or DebugGrid. What am I missing? How do I enable this?

bartolomesoriano commented 7 years ago

@mistervee, I couldn't find you in Skype, what info is shown for you?

bartolomesoriano commented 7 years ago

From @meowmoo on May 17, 2017 19:11

yes F7 F8 Did not work

need to install skype, I have 2 weeks off now, and I need some work :P

bartolomesoriano commented 7 years ago

From @mistervee on May 17, 2017 21:35

@bartolomesoriano @meowmoo Should be working now. Github was set to exclude the xml needed for the buttons to work.

I'll pm you guys my email address through the kodi forums. Should make finding me easier.

MadMikeDoc commented 7 years ago

I'm working on 507 - Fanart List.

meowmoo commented 7 years ago

pushed 700 rightlist, pls take a look at the OldMadnox one and tell me what we need/want. or should I just polish it with the least info possible and we add all the stuff back at the end

mistervee / skin.madnox

Viewtype Rework #13