mistervee / skin.madnox

Other
13 stars 13 forks source link

DialogSeekBar #15

Closed bartolomesoriano closed 5 years ago

bartolomesoriano commented 7 years ago

@mistervee, @meowmoo, @MadMikeDoc, as you know, DialogSeekBar shows up both when you are seeking (RW or FF), and also when a video is paused. I am looking for your opinions as to what we should show on the secreen when seeking and when paused.

Please look here for some variations, including what we do today in MadNox Krypton:

http://imgur.com/a/4cBSC

In MadNox Krypton, most of the options shown in the Paused screen can be toggled.

What do you think? What do we want? Once you provide your opinions, I would like to take a first pass at updating this xml. Thanks!

mistervee commented 7 years ago

@bartolomesoriano

My thoughts would be similar to omni. Should just be a copy and paste from the videoosd.xml minus the buttons.

Makes me think there a a few xml's associated with fullscreen video. They need to work in a seamless fashion. It is worth considering making sure all xml's in this area are updated at the same time.
videoOSD.xml dialogseekbar.xml dialogplayprocessinfo.xml dialogfullscreeninfo.xml videofullscreen.xml

For the options, i would wait until the above xml's are updated.

@all For the videofullscreen.xml there are label id's 10,11,12. Any idea on what they do and how to get them to display? http://kodi.wiki/view/Skinning_Manual#VideoFullScreen.xml

Edit: the id's change the viewmode and show video information. 'z' on the keyboard

MadMikeDoc commented 7 years ago

Do you mean like omni for both Seek and paused? just for the 1st version and then re-add all the Madnox paused options that can be toggled?

mistervee commented 7 years ago

@MadMikeDoc Exactly like omni for seek paused, FF ect. Same as the current videoOSD.xml seekbar with the player labels replacing the title.

The plan is to add the options later when the basic functionality is finished. It will mean scrapping the old code and starting fresh.

bartolomesoriano commented 7 years ago

Very well, I will take a first pass at it.

@mistervee, I could not find DialogFullScreenInfo.xml in the Kodi skinning manual. Do we need it? @MadMikeDoc , what were we using it for?

mistervee commented 7 years ago

@bartolomesoriano Full screen info has no required control id's. It is the dialog you see when you press the info button.

bartolomesoriano commented 7 years ago

@mistervee , thanks. How does this differ from DialogVideoInfo? I thought that was the dialog you see when you press the info button.

meowmoo commented 7 years ago

I think DialogVideoInfo, shows up when you press info on a movie/TV show in your library.

bartolomesoriano commented 7 years ago

@meowmoo, as opposed to when you press info while watching a movie or tv show? There is where DialogFullScreenInfo shows up? I am away from my machine now, but will test tonight to confirm.

mistervee commented 7 years ago

videoinfo = library browsing fullscreeninfo = for video playing

Best way is if you have that keymap installed i posted a while back, press F6 for for the debug info, which will tell you what xml is active.

mistervee commented 7 years ago

@bartolomesoriano The videofullscreen.xml id's 10,11,12 change the viewmode. Use 'z' keyboard to change.

bartolomesoriano commented 7 years ago

@mistervee, thanks. I wasn't able to test anything last night, my HTPC broke down. I will test tonight. I didn't know about the viewmodes. Thanks.

bartolomesoriano commented 7 years ago

@mistervee, @MadMikeDoc, @meowmoo, please test DialogSeekBar when you can. I couldn't figure out how to make it work when the VideoOSD is active. Thanks!

bartolomesoriano commented 7 years ago

@mistervee, @MadMikeDoc, @meowmoo I made it work with VideoOSD by changing the label in the center in VideoOSD match the label in DialogSeekBar, but there must be a better way. Please review. Thanks.

mistervee commented 7 years ago

@bartolomesoriano This is a tricky one. Give me some time.

meowmoo commented 7 years ago

I think its kinda big for a seekBar. But well done @bartolomesoriano

bartolomesoriano commented 7 years ago

@meowmoo, thanks! I think it's too big also. I need to experiment making it lower but making sure it blends in with the VideoOSD. Thoughts?