mistervee / skin.madnox

Other
13 stars 13 forks source link

Panels #16

Closed ArieS1204 closed 5 years ago

ArieS1204 commented 7 years ago

First of all, I hope I can use this section for discussion and that it's not only for issues with the coding. Or else feel free to delete/move it.

Anyway, thoughts, comments?

http://imgur.com/a/zoQUE

bartolomesoriano commented 7 years ago

@ArieS1204, I like the look, thank you! It looks elegant and professional, understated, which are all qualities I like. The only thing I would say is to ensure all the elements fit well within the panels; for example the studio logos seem to overlap with the panel border, and the radio buttons for the options seem too close to the panel border.

mistervee commented 7 years ago

@ArieS1204 This is the perfect place to discuss such things.

Very nice indeed. Perfect.

@bartolomesoriano As for the elements not fitting, This is to be expected as the alignment is suited to what we have now. So it will require a code update, which can be done rather quickly to suit the textures.

meowmoo commented 7 years ago

welcome @ArieS1204, you are from fanart.tv right?

I also like the textures, looks well done, someone who knows how to use Photoshop is always welcome :D

ArieS1204 commented 7 years ago

Thanks all and glad you like them. Let's see what @MadMikeDoc thinks and if he likes them too. If he does, are we moving along with these or do you want other designs to choose from? Panels are panels so there's not a lot more I can do but if you want I can try to come up with other ideas.

@meowmoo, thanks for the welcome and yes, I'm the ArieS from fanart.tv :)

mistervee commented 7 years ago

@ArieS1204 @MadMikeDoc If mike is all good we will move to the next area.

MadMikeDoc commented 7 years ago

@mistervee @ArieS1204

All good from me, nice to see all areas now improving and good work Aries.

MadMikeDoc commented 7 years ago

While working on FanartList view I noticed i used a different background panel, tried using the standard from List view but not 100% it fits the view right, will pull these and give them a try otherwise will add back the original texture I was using in FL Krypton..

mistervee commented 7 years ago

@MadMikeDoc All good. We will probably run around in circles for a bit, until we get the exact look of the skin down.

ArieS1204 commented 7 years ago

Just for fun I was working on the radio buttons. I like A better than B but for some reason B looks better in Kodi... http://imgur.com/a/doVIO

Also the glow color for the ON button could be used by the Color Picker thing. Would that be something you would want to change and I was just wondering how much textures/images do you want to change?

@mistervee Should I PM you the panels I made so you can start aligning text and such to them or do I need to modify them?

MadMikeDoc commented 7 years ago

@ArieS1204 , we hope and plan to keep some of Schimi's work in honour to him but I would say all textures are open to improvement, His cases and things like that will probably stay the same I think.

B looks like the 'metal' ones we have now from Schimi and probably better in Kodi like you say.

Just look into whatever and either post here or in another general Textures issue.

I think the panels are good to go and we can start using them and then see if they need modification or not, but @mistervee will let you know.

mistervee commented 7 years ago

The color picker needs to be considered for any textures. As you can choose an infinite amount of colors. Having a blue button wont play nice with the code. So most textures need to be black and white. Keeping in mind that when a tint is applied by kodi, the darker the texture less tint is applied. If needed i can add the colorpicker to the buttons. It is hard to really know how to shade the buttons unless it is in the skin

PM me the textures and i will have a look. From the screenshots the textures look great but i cant really say if they need modification until i see how they work with the code.

bartolomesoriano commented 7 years ago

@ArieS1204 I lreally like your work, but my preference would be to keep the radio buttons we have now.

meowmoo commented 7 years ago

@ArieS1204 this looks very well done! I like them both :D

if we gonna change them im for B

ArieS1204 commented 7 years ago

@MadMikeDoc, keeping schimi's work sounds great to me. What he did was great anyway. To be honest, I'm not sure what is from Nox 4 and what is from schimi, anymore. It's been so long since Nox 4 that I thought the radio buttons were from back then. @mistervee, that's what I was trying to say. The glow could be white overlay so whatever color people have the skin on, it would be of that color. I just suck at explaining hehe. @bartolomesoriano, fair enough. Like I said I was just messing around with them. @meowmoo, thanks for the support hehe.

But really, you guys tell me what you need and I'll give it a go.

bartolomesoriano commented 7 years ago

@ArieS1204 , I didn't understand the fact about the color, I thought it was just blue. In that case, I am with @meowmoo , if we're going to change, I vote for B :) Were you able to PM the textures to @mistervee? I would love to see them in action!

ArieS1204 commented 7 years ago

@bartolomesoriano I just sent them to @mistervee.

meowmoo commented 7 years ago

@ArieS1204 I would love to see a "playerbutton" from you https://github.com/mistervee/skin.madnox/blob/master/media/buttons/player/play.png just curious, which designe you would come up with :)

btw is the A button made from scratch? if you fit this one in nicely it will also look very nice, I think I wannt A know ^^

bartolomesoriano commented 7 years ago

@ArieS1204 , I am a big fan of color, so this is my wishlist :D

I know most of these are provided as image resource packs, but it sure would be nice to have our own image resource packs where that makes sense. I have always loved all the colored icons and flags from MadNox, and at one time even had colored main menu icons that schimi shared with me. Couldn't share those with the skin for everyone back then, since they were not public domain.

@mistervee , @MadMikeDoc , @meowmoo what do you think?

mistervee commented 7 years ago

@meowmoo @ArieS1204 I am hoping to stick with material design through out the skin. It is a lot of work to redesign 50-100 icons. So i would think it is just the background and focus for the media buttons. If we change the icon in the center of the button we may have to change the others for a consistent look. https://github.com/mistervee/skin.madnox/blob/master/media/buttons/player/template.png https://github.com/mistervee/skin.madnox/blob/master/media/buttons/player/osd-focus.png

@bartolomesoriano @ArieS1204 For the time being we have all the required colored flags and icons from madnox. A lot of the flags are from schimi that we plan to keep. I need to put together a pack and work out what is missing. What needs to be done are some slight tweaks and adjustment to white spaces.

It may be a while before i can get the flags sorted, this will take many hours and there is lot of things that needs to be worked on first.

meowmoo commented 7 years ago

@mistervee sure thing we keep them, like I said just curious :)

mistervee commented 7 years ago

@ArieS1204 @bartolomesoriano @meowmoo @MadMikeDoc

Just thinking about the buttons. I like Aries version B. It seems to fit the new panel design well. The button here https://github.com/mistervee/skin.madnox/blob/master/media/buttons/radiobutton-on.png is nice but does not fit the design of the new panels.

Any thoughts on meeting in the middle and making it a combination of the two designs?

bartolomesoriano commented 7 years ago

@mistervee, what exactly do you mean? I am afraid my visualization skills don't measure up here to provide an intelligent opinion. If what you propose is that either you or @ArieS1204 come up with a button design that is a combination of what we have and @ArieS1204 option B, then I say go for it.

MadMikeDoc commented 7 years ago

so a metallic version of B then as Schimi's existing was a metal type of button?

bartolomesoriano commented 7 years ago

@MadMikeDoc that sounds good to me :)