search

mistervee / skin.madnox

Other
13 stars 13 forks source link

Theme/Colour Picker Feedback #21

Closed mistervee closed 4 years ago

mistervee commented 5 years ago

Check out Setttings/Addons.

Please install Required/Recommended/Optional.

A few things to note;

Known issue/Changes required;

bartolomesoriano commented 5 years ago

@mistervee, well done!

I have updated to the latest from Git, and everything seems to be working fine, thank you!

I tested changing texture and style on the main menu, dialogs, etc. and this works perfectly. I am favoring the "Concrete" texture at the moment. :)

I have tested the color picker, tweaked to my preference (exactly how I had the old MadNox) and it looks great. I had no problem selecting the items/colors I wanted, and no errors in performing these functions.

I was able to save my theme, and I then reverted to the default theme, this worked fine, and then reapplied my custom theme, and this works great also.

There are a lot of different areas of the skin that you can choose colors for, so I think this might be a bit overwhelming for casual users (which we are not, of course :) ). The idea of a lot of default themes seems great to me, and having a screenshot of what the theme looks like will be necessary, I think. That way the user can have a better idea of what the changes will look like.

The first issue I am having is that when I enter dialogvideoinfo for a movie I get a colorbox script error, I need to investigate this further.

The second issue is that when I enter Settings/Addons, even though I have installed all of the Required addons, it shows that I don't have them. I think this might be my install and not a skin problem, since I have the addons installed in Program Files/Kodi/addons instead of the userdata folder.

All in all, it's coming along great, thanks again! The skin looks elegant and polished!

I am ready for the next round!

mistervee commented 5 years ago

@bartolomesoriano

I was thinking it may be a bit overwhelming myself for all the theme choices. For simplicity sake the themes under save/restore should make it simple. For advanced users it gives choice if they want to fine tune things. Not sure if i should simplify theme/color options for the advanced stuff or i should leave it as is.

Screenshot wise, the skin theme backup plugin supports this so no issue adding that for predefined themes.

Concrete theme is what i like best too.

Just checked the colorbox script error. Same from my end. Not sure atm it was working. I will have a look in the future.

For the plugins you will get a not installed if you do not have the latest beta skin helper repo. Here; https://github.com/marcelveldt/repository.marcelveldt Direct Link; https://marcelveldt.github.io/repository.marcelveldt/repository.marcelveldt/repository.marcelveldt-1.0.1.zip So you should get a pop up saying download beta repo. Download the repo and then in kodi install from the repo form zip file (browse to your download location) . After that the addons should update and you should then have all green check marks of the beta installs.

mistervee commented 5 years ago

Feedback from Gibxxi/Dan

I tried all 3 themes, and I like all of them. I especially like the "square" and "Emboss" options, although i think it might be more descriptive to the end user to call that effect a "highlight", as an "Emboss" effect, to me, would indicate an effect covering an entire surface.

I had no problem changing themes, but did not test colour changes (at this time). I'll come back to that when I have more time. I want to enjoy the "stock" look a bit longer, before I start creating (or attempting to create) garish colour schemes, lol. One thing (that was dropped in Madnox) that I liked in Shednox, was the "Global Blue Overlay" effect. It made the whole UI look a bit "Misty" and mysterious looking, maybe one for future consideration?

gibxxi commented 5 years ago

@bartolomesoriano:

I would advise against putting 3rd-party addons in the program files folder (under kodi's own, internal "addons" folder), as I think the Kodi installer may wipe this folder each time it runs / upgrades your local install.

What I do is run my installs as "portable" all the time, and then I can not only choose where I want Kodi installed (i.e: not on my precious SSD) but also where all it's associated cache and clutter files get installed, like the "Thumbnails" folder for example.

gibxxi commented 5 years ago

... I also don't need to keep typing "%AppData%" into Windows Explorer's address bar just to find it.

;)

bartolomesoriano commented 5 years ago

@mistervee, @gibxxi,I reinstalled Kodi from scratch yesterday, everything in its default location. I redid my tests of colors and styles, everything is working fine except for the colorbox error.

Before opening new issues, especially with views, which views beside list have you coded? I don't think it's productive to open issues on views you have not coded yet, or for widgets, for example.

mistervee commented 5 years ago

@bartolomesoriano @gibxxi

I completely agree with you @bartolomesoriano.

I do find it a bit overwhelming all the additional issue's that have been posted.

However i like the feedback no matter what it is. It is a big help on what to focus on and help me move forward.

What i think is best if you want to open a new issue go for it. Keep in mind things are not finished and many areas of the skin and as @bartolomesoriano said it is not productive to open issues on what is not coded yet.

Saying that it is difficult for new people i have added as they will not know what is or is not complete/coded.

I just cleared out all the issue's a few days ago for a fresh start...

So if you want to create a new issue for anything please keep it just to one view/element of the skin. For example the low list view. I see multiple issues posted for that view. It would be preferable to have only ONE issue open for lowlist and those ideas in only one post. It makes it so much easier to track the issue. May be some dot points on what you think needs improving. Things are unfinished and it is a great placeholder/guide for me moving forward. I do have a bit of OCD myself and will make every effort to make things pixel perfect in the long term.

gibxxi commented 5 years ago

Don't be discouraged by the issues m8. If I had a penny for every mistake, or error I've made on a various "projects" over the years, i'd be a very-very-very rich man, lol. When you consider the number of fixes Aeon Madnox has required, a certain level of bug-fixing was always going to be necessary.

Besides, that's why we're here, isn't it? So we can identify these issues now, so that the skin will be the best it can be, before it gets properly released. I agree and concur with @bartolomesoriano. If you could let me have a list of things that are not yet finished / on the to-do list, then that will forestall me reporting issues to do with those items, which would also save me time. Getting the screen-caps, uploading them, getting the links, posting them back here, etc. is a bit of an arduous task in itself, so I'd rather not report something that's still in development, as that will free me up time to look for "real" issues.

With regards issue-reporting, read & understood. As I said above, the least number of separate posts I need to make, the more time that free's up for testing.

gibxxi commented 5 years ago

I did notice that there were a few posts on the forum thread, asking for testing access. Nothing against anyone who has stepped up, but I would be somewhat "cautious" about whom you give testing access to at this stage. Both for the reasons already discussed, and the potential quality (or lack thereof) of the feedback you receive.

The project needs to keep it's direction & focus, and this could be somewhat derailed if the quality of the feedback your getting, is less than ideal. I appreciate there will be a lot of people wanting to test out your work, but much like Kodi itself, which goes through "Alpha", then "Beta" stages before final release, I think it's a bit too early to be opening this up to the general public at this point in time (IMHO).

mistervee commented 5 years ago

@gibxxi Hi mate, cheers for your feedback. This is new to me in some way. I am coding this skin a bit out of my depth and have been learning along the way. Before i asked for people to help test it out it has been 12 months of progress.

So If yourself and others can bear with me that would be great. I will post in github what i believe is complete and await feedback.

New issue opened to list things that are finished or not. https://github.com/mistervee/skin.madnox/issues/29

In regards to testing access, i looked at yourself and others, your post history and contribution to the Kodi forum. So i was rather cautious in who i invited. Yourself and @Slipass was who i invited. Two more to come

gibxxi commented 5 years ago

@mistervee

I figured as much with regards your selection of volunteers, but thought it worth mentioning anyhow. Like I said, not wanting to diss anyone here, but flooding GitHub with non-issues probably isn't desirable at this stage, regardless how well-meaning the intention.

I will take a look at the issue (#29) after posting this message.

I'll also endevour to give the colorpicker code a run-through over the next 24 hours. I've been somewhat busy this past few days with side-issues, so apologies for that. I'll also go through those things you've closed and report my findings.

Keep up the good work.

;)

Dan / Gib.

mistervee commented 5 years ago

@gibxxi

Cheers Dan.

One thing i forgot to mention. The "Global Blue Overlay" effect. It is still included. Enable Shadow under SkinSettings/Themes/Backgrounds. Then change the colour - SkinSettings/Colours/Backgrounds.

gibxxi commented 5 years ago

@mistervee

Thanks for the info.

:)

This might be something on my end, but I am unable to switch / load the Aeon Auriga theme. If selected, it starts to switch the colours / textures but the Kodi force-quits to desktop.

The home menu bar texture for the "White" theme is missing what appears to be a background. At the edges, it's transparent, and the transparency itself is wider on the right hand side of the home menu, than it is on the left.

The colour-picker works as expected, but I would say it might be a good idea to have a "reset to defaults" option, for if somebody makes a raft of changes, then gets lost, there's then a way to get back to the default values for that theme, without having to switch to another theme, then back again to restore the default colour selections.

In the status bar on the colour picker, "ff0000" (for example) is displayed. Which is the currently selected colour. But there's no label telling the user this, or why it's there. Perhaps it might be an option to have it look something like this:

Current: ff0000 / Selected: ffff00

With the "Selected" part changing to match the colour currently highlighted in the colour-picker.

With regards theme changes, I think it might be a good idea to either have a dialog box with a progress bar or a transition screen with a "fade to black" and then a "fade to new theme" effect, as there's no indicator as to when the theme switching / loading is complete atm, and the speed can vary depending on what else Kodi is doing in the background.

I'd favour something like dimming the background 80% with a progress dialog box indicating the change of theme with some text like "Please Wait: Changing theme to XXXXXXX" then have it return to normal on completion.

I have a few other things to post, but don't have time to post images / in-depth reports atm, as I'm going out for the day. Will elaborate on all of the above later when I have more time.

mistervee commented 5 years ago

@gibxxi I was having the same issue, what i found was to load the default theme first.

I have looked into this further. There was a change to the way the busy dialog was called for addons. I think this also caused the issue of kodi closing. https://forum.kodi.tv/showthread.php?tid=333950

Not 100% sure if it will fix kodi closing as i have no idea how to code python, but try changing these parts of the plugin code. It seemed to work for me.

Search "busydialog" (10 hits in 3 files) C:\Kodi\portable_data\addons\script.skin.helper.colorpicker\resources\lib\ColorPicker.py (2 hits) Line 149: xbmc.executebuiltin("ActivateWindow(busydialog)") Line 194: xbmc.executebuiltin("Dialog.Close(busydialog)") C:\Kodi\portable_data\addons\script.skin.helper.skinbackup\resources\lib\colorthemes.py (7 hits) Line 145: xbmc.executebuiltin("ActivateWindow(busydialog)") Line 164: xbmc.executebuiltin("Dialog.Close(busydialog)") Line 237: xbmc.executebuiltin("ActivateWindow(busydialog)") Line 297: xbmc.executebuiltin("Dialog.Close(busydialog)") Line 342: xbmc.executebuiltin("ActivateWindow(busydialog)") Line 388: xbmc.executebuiltin("Dialog.Close(busydialog)") Line 391: xbmc.executebuiltin("Dialog.Close(busydialog)") C:\Kodi\portable_data\addons\script.skin.helper.skinbackup\default.py (1 hit) Line 36: xbmc.executebuiltin("dialog.Close(busydialog)")

I just opened all the py files in notepad++ and did a find and replace in all open documents. So replace 'busydialog' with 'busydialognocancel'

If it works your end i will submit a pull request for the skin helper addons.

For the reset to defaults you should be able to pick the default theme in backup/restore. Although in future i will add an extra button to reset all the skin strings.

Makes sense for the color picker dialog for the current/selected. I will update the dialog soonish with the next update.

Edit: On the next update i will fix the auriga texture. I modified the original but missed that part.

EDIT2: I will update the first post with known issues

mistervee commented 5 years ago

@gibxxi I am not sure if there is a way to separate what is the default color vs the selected color. Added a label to the default/selected color to make it clear.

Updated Aeon Auriga main menu textures.

gibxxi commented 5 years ago

Selected Aeon Auriga again, and it's no longer crashing Kodi. However, theme changes now, while faster than before, are only affecting panels, and sub-sections. The Home screen theme does not change from default. Tried a restart, and it still does not load custom themes.

On the bottom (System-Tab) pop-up, the white icons are practically invisible behind light-coloured backgrounds (like the one showing the laptop keyboard, for example). So these icons may need a black outline, or some kind of minor shadowing to make them stand out on light backgrounds.

gibxxi commented 5 years ago

The added label for the colour picker is fine (although you may want to add a colon after "colour"). Other than that, it clues the user in to what the purpose of that status line is, so it's OK as is in terms of detail. No need for any extra detail as it stands. The fact that the hex is coloured the same as the colour selected ought to be enough for most users. :)

gibxxi commented 5 years ago

...oh and thanks for the "reset" button. ;)

mistervee commented 5 years ago

@gibxxi I deleted the pre-defined themes and changed a few variables.

How i made the predefined themes is simply to select whatever color/theme choices within the skin. Then backup, and move the backup to extra/skinthemes folder. I am thinking that due to certain skin strings not being present when loading a theme was causing crashing, hence why i deleted the themes. So when we get closer to finishing the theme/colour variables, predefined themes then can be added back to the skin. Not sure how you loaded any predefined themes as they were removed.

Removed an extra space in the color picker dialog. Personally i don't like using semi-colons and would rather avoid them by using different colors to separate information, like the topbar.

Updated the extra button menu on the home screen and added an extra color option for the buttons. Thanks for this, it was something i missed when i changed the texture some time ago.

Cheers mate for your feedback. Keep it coming :)

mistervee commented 5 years ago

@all

Forgot to mention. Might be a good idea to reset the Color/Themes. There has been a bunch of changes that will effect the skin strings stored in the madnox settings file.

If you are still finding strange things happening with colors/themes, you will need to close kodi and delete the madnox settings file.

This will revert back to the theme that is intended on first install. So if you have any feedback on the default theme that would be great i.e. preferred colors and textures

gibxxi commented 5 years ago

@mistervee

Colon m8, not semi-colon. Again, up to you. I'm a bit of a grammar Nazi, as well as being OCD, so apologies in advance. ;)

Good point. I moved the GitHub Sync directory to solve the nested "add-ons" folder issue I was getting I mentioned before, then re-synced to Kodi with SyncBack Pro. I excluded the Skin-shortcuts file from any modification / deletion by said app. I will try the settings alteration, by renaming the file first. Changed or configured a lot of stuff, so want to be absolutely sure first, before I have to go in and redo all my configs. ;)

gibxxi commented 5 years ago

@mistervee

Leftover title / setting header for "Themes and Colours" in the "Skin Settings" -> "General" area...

https://imgur.com/bqehNpZ

Dan / Gib.

mistervee commented 5 years ago

@mistervee

Leftover title / setting header for "Themes and Colours" in the "Skin Settings" -> "General" area...

https://imgur.com/bqehNpZ

Dan / Gib.

In future i will be adding a reset and pre-defined theme buttons under this. Just a place holder for now.

mistervee commented 5 years ago

@bartolomesoriano @gibxxi @meowmoo

Just pushed a fix for widget thuimbnails.

Doing so i also pushed my WIP of the Theme and Color picker improvements. So you might see some strange behavior with the look of the skin and may need to reselect your colors and themes.

gibxxi commented 5 years ago

@mistervee

Rgr that. I'm right in assuming a "stock" setup will be unaffected? (I've not messed with colours / themes thus far).

mistervee commented 5 years ago

@gibxxi

You will see slight difference in floor texture, that's about it.

meowmoo commented 5 years ago

@mistervee widget works now, thanks.

mistervee commented 5 years ago

@bartolomesoriano @gibxxi @meowmoo @Slipass

Due to the recent update your custom themes and colors will likely not be working as intended. Possibly even the default theme.

Recent updates

You will need to reset the theme Go to skin settings -> general -> themes and colours -> RESET

mistervee commented 4 years ago

DONE