Closed gibxxi closed 4 years ago
@gibxxi Just pushed some updates.
Let me know if it has fixed anything. I am unsure about the "right-hand side of the dialog box being largely unused".
For the library scanning dialog boxes it's not so much an issue, but for add-ons, especially like Trakt, having the text in the dialog box "left-justified" means there's a large amount of empty space on the right hand side of the dialog that's unused. So I suggested centralizing the text for add-ons at least. However, this may work for some add-ons (notifications) better than for others.
The progress bar is also flat on the right hand edge, and rounded on the left-hand edge, that's what my screenshot attempted to show.
@gibxxi
It is kind of a tough one to make it work for notifications where there is an empty space on the right. It is out of my control then length of characters. My preference is not to centralize the characters, hence why it is left justified.
For the progress bar being flat on the right, i cant see any issue from my end, saying that if the screen you are using is not exactly 16x9 that would happen, i have done further code updates that hopefully should fix the problem.
OK. I might be suffering from the common issue in Kodi, that's no fault of your own, whereby sometimes a lot of progress dialogs shoot to 99%, stay there for some time, then disappear before 100% is ever reached.
Either way, I watched a library scan progress to completion today, and it seems to be OK now.
With regards pop-up dialogs, I think left-justified works fine for things that have long blocks of text like library scans, not so much for add-ons where both the title and sub-text can be, and often are fairly short. But It's your call, I'm just offering you my feedback, it's your skin, after all. Not a major issue for me, just an observation. :)
The dialog box may need to be a bit lighter in shade though. As it tends to blend into a lot of the darker backgrounds so much so that it's borders are invisible against the background colour. This can be somewhat subjective, depending on the colour accuracy of the monitor in use, but on my Iiyama E2283HD sometimes all I can see is the text, and not the dialog box surrounding it.
@gibxxi
Cheers for the feedback.
Good find on the scan dialog texture. The texture does not match the colour's of the the other dialogs. Not intentional. Pushed to git.
OK, will take a look shortly. Thanks!
DONE
When using the "Small" progress / pop-up dialogs option, the right hand side of the progress bar is truncated / missing.
https://imgur.com/J2iNOno
Additionally, I think the large (default) option either needs the size of the text centre-aligned, or increased in scale, as currently, i'm seeing the right-hand side of the dialog box being largely unused / empty. Maybe (if not already present) a scrolling option for text overspill. Again, thoughts?