mistervee / skin.madnox

Other
13 stars 13 forks source link

Live TV / PVR / Radio Feedback #33

Closed gibxxi closed 4 years ago

gibxxi commented 5 years ago

Currently, on my system, using a HDHomeRun Connect (HDHR4) the "Radio" main menu item is unpopulated (empty). Not sure if this is a skin issue, or a Kodi / add-on issue. As it stands, all my radio channels appear under the "Live TV" menu item.

Anyone else here have an alternate PVR back-end setup they can test to see if this is something specific with my hardware / add-on setup, or Kodi add-on / Skin related?

bartolomesoriano commented 5 years ago

@gibxxi, I do have alternate backend (Simple IPTV, m3u), but it does not offer radio channels. In any case, I will configure it in my test machine and provide feedback on Live TV/PVR.

gibxxi commented 5 years ago

Cheers. I have a feeling this is add-on related rather than skin-related but I can't be sure unless someone with a different setup can confirm.

On Oct 14, 2018 3:44 PM, bartolomesoriano notifications@github.com wrote:

@gibxxihttps://github.com/gibxxi, I do have alternate backend (Simple IPTV, m3u), but it does not offer radio channels. In any case, I will configure it in my test machine and provide feedback on Live TV/PVR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mistervee/skin.madnox/issues/33#issuecomment-429632107, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGyQ6jwin1ZQyVgiXE2-gs8YcB2PCm13ks5uk03DgaJpZM4XbHE2.

mistervee commented 5 years ago

It is either add-on or back end related. I use NextPVR and don't have any issues.

Generally speaking the skin relies upon the backend/plugin to separate radio and tv channels.

gibxxi commented 5 years ago

The add-on I was using for the HDHomeRun (The DVR version) hasn't to my knowledge been ported / updated for Leia yet, so I'm using Zoltan Csizmadia's "PVR" version, which doesn't do recordings, so this may become a non-issue.

There's at least 3 different HDHomeRun plugins floating around, in addition to SilliconDust's, which is a video add-on, not a PVR plugin anyway. So at this time I cannot test recording functionality. Recording with the custom QNAP recording back-end add-on, and the HDHomeRun "View" app, works fine, so I'm hoping the same goes for the other add-on I was using, and that there's proper TV / radio channel separation in that add-on, if/when it gets an update.

Please leave this thread open, for other "DVR/PVR" skin-related issues that may pop up later.

:)

mistervee commented 5 years ago

@gibxxi

Just a thought, you can disable the radio item for the home screen. Everything should function normally without separating radio/TV if the plugin does not provide separate radio/TV support.

No plans on closing this thread anytime soon. Still loads of coding to do for the PVR.

gibxxi commented 5 years ago

Yeah I know. Did this before with several categories in Aeon Madnox I don't use, like "Music Videos", "Games", etc. But it would of been nice had it worked. Not your fault, but navigating to radio channels is a bore with everything in the one list, as they usually come at the bottom here in the UK listings.

Ho hum, lol.

mistervee commented 5 years ago

@bartolomesoriano @gibxxi

Updated github with the PVR guide.

The general layout is complete. I am having some issues with the icons for recording/timers ect. Also have not added skin helper service for tv shows and movie artwork, that will be added in time.

Otherwise it is done.

Open to feedback and suggested improvements!

bartolomesoriano commented 5 years ago

@mistervee, thanks! I have been using it today and in general, I like it! The only things that come to mind, without thinking of too many customizations, are:

  1. I would like a way of getting to the different channel groups without having to press M to go to the sideblade. Maybe buttons on top of the guide that could be accessed by pressing up from the first channel?
  2. Having a scrollbar on the channel list
  3. Have the channel name scroll if it is too long.
  4. Have a fallback icon if the channel does not have an icon

Now, looking into possibilities, I think this proposed mod to the old MadNox (which was not included in the end, has some great ideas for PVR: https://forum.kodi.tv/showthread.php?tid=256456

In particular, I like the channel view that shows you what's playing now and what's playing next at the same time.

Also for ideas, this Estuary Mod has some interesting ones (some are similar to the ones above):

https://forum.kodi.tv/showthread.php?tid=325600

I have not tested other PVR areas, since I don't do recordings or timers at this time, and concentrated on the guide before anything else.

What do you think?

gibxxi commented 5 years ago

Much like bartolomesoriano, I can't test "DVR" functionality yet, as the PVR add-on I'm currently using, doesn't support it.

The "Guide" screen looks fine. 8 channels is enough, and leaves a good amount of space for a fairly detailed synopsis, i'd leave that part as is.

With regards the sideblade, in Aeon Madnox you could use the "Up" or "Left" arrow keys to open the sideblade (depending on configuration, so it might be worthwhile doing similar here. I'd prefer the "Left" arrow key as I don't think we want / need to make vertical (channel) scrolling a fixed list, but not only that, do we really need to be able to scroll left so far as to show programmes that have already been aired two or three hours prior to the current timeline?

I'd suggest some form of "backstop" when scrolling left, that then opens the side-blade when the "Now" timeline marker is centred on the screen or something. My main usage of Kodi is via TV/HTPC with a NYXboard remote control. OK, it has a keyboard on the other side, but there will be a lot of people who may use "universal" remotes that don't have this feature. I think we need to rely as little on keystrokes and / or mouse movement as much as is possible (IMHO).

One issue noted: In the guide screen, with the side-blade open, the view-type has an icon, but no text-label. The text label is present on other panels in the PVR section (Channel list / recordings?).

mistervee commented 5 years ago

@bartolomesoriano @gibxxi Done and Done, all updated and fixed, thanks, I missed a bit and your feedback helped a great deal.

I like the ideas of the blue and estuary mod. I will get to that when i update the library views as i will use the same code with different variables.

I have added the PVR Info dialog. So 'i' for info in the various pvr views. There is a also a nice YouTube button if you have extended info installed. It works 90% of the time. you may see an error, which is a plugin issue. I do have a fix, i will post when i get a chance.

bartolomesoriano commented 5 years ago

@mistervee, thank you! Appreciate the changes. I think that having a scrollbar for the channel list is a good idea (it is not there now), in particular when using PVR clients that have a large number of channels.

Apart from that, it is working well for me.

mistervee commented 5 years ago

@bartolomesoriano Just in case of any conflicts i have changed the scroll bar id (was working from my end). The scrollbar is there in the right hand side of the pvr guide. Not so easy to navigate to but it is there.

gibxxi commented 5 years ago

@mistervee:

Just a heads-up, the update to the HDHomeRun DVR addon I was using in Krypton has now been posted, making it usable in Leia (RC1+) too.

https://github.com/djp952/pvr.hdhomerundvr/wiki/Downloads-for-Kodi-Leia

I will get this installed and setup over the coming days. Once complete, I'll once again be able to test recordings and other PVR functionality not available in the HDHomeRun add-ons currently available via the Kodi repo.

Dan / Gib.

gibxxi commented 5 years ago

Have an issue with PVR in relation to the "Start music playback on visualisation screen" setting. Can't remember the exact wording of the setting atm, but essentially, if you have Madnox set to go straight to the "Music Visualization" screen upon playback start, this setting is also being invoked for ALL PVR channels, be it Radio or TV. In the case of TV channels, the video isn't visible, but the sound plays as normal.

Pressing [Backspace] once, cancels the "Music Visualization" screen and the normal (fullscreen) video stream is then displayed. This is using the HDHomeRunDVR PVR addon mentioned above.

Dan / Gib.

mistervee commented 5 years ago

Cheers for the report.

Fixed now on git for Live TV. Auto fullscreen will work for radio and music only.

gibxxi commented 5 years ago

Thanks Mr. V!

:)

Dan / Gib.

gibxxi commented 5 years ago

@mistervee

In the PVR section, when viewing timers for upcoming "Record Once" programs, all options are greyed out. It's not possible to edit channel, padding time or any of the settings for this timer. Also, it is not possible to use the cursor keys to navigate to either "OK" or "Cancel" buttons. Buttons are selectable with the mouse though.

https://imgur.com/bcJUeDV

Also, the setting to view the timer rule is duplicated in the context menu (View & View Timer Rule) - both do the same thing.

https://imgur.com/VTZonHW

Also, for the "channel" row, I would add a colon or hyphen between the channel number and the channel description to make it clearer what is the backend channel number, and what is the description, e.g:

4: Channel 4 or 4 - Channel 4 (for example).

Dan / Gib.

gibxxi commented 5 years ago

...While I'm on PVR, could we have an option to display channel logos in the EPG guide (instead of text labels) please? Obviously, if no icon is found, then fallback to text for that channel. I would keep the text labels for channel numbers in the left hand side, though.

https://imgur.com/sy0nO1X

Dan / Gib.

mistervee commented 5 years ago

@gibxxi

I cant repeat this behavior on my end and do not have the option for record once, perhaps to do with what pvr backend i am using? The dialog that pops up is DialogSettings.xml. The controls you see are in the kodi core, there is only so much i can do.

For the context menu the Skinner has no control with what appears.

For the channel row, i assume you mean the dialog popup, there is no way to change the values. It is in kodi core or the pvr addon.

Can you check if you have the same issue in Estuary? and just to be sure you are using Kodi Leia?

mistervee commented 5 years ago

@gibxxi

...While I'm on PVR, could we have an option to display channel logos in the EPG guide (instead of text labels) please? Obviously, if no icon is found, then fallback to text for that channel. I would keep the text labels for channel numbers in the left hand side, though.

https://imgur.com/sy0nO1X

Dan / Gib.

Can do. When i get to updating the pvr.

gibxxi commented 5 years ago

@gibxxi

I cant repeat this behavior on my end and do not have the option for record once, perhaps to do with what pvr backend i am using? The dialog that pops up is DialogSettings.xml. The controls you see are in the kodi core, there is only so much i can do.

For the context menu the Skinner has no control with what appears.

For the channel row, i assume you mean the dialog popup, there is no way to change the values. It is in kodi core or the pvr addon.

Can you check if you have the same issue in Estuary? and just to be sure you are using Kodi Leia?

@mistervee

I'm using Leia 18.3 m8. I'll take this up with the addon developer. I thought it may not be skin-related, but wasn't sure, so put it up to cover the bases.

The option is simply labelled "Record" in the context menu, but applies to both currently airing programs, as well as future recordings in the timeline that are selected with this option. There's a seperate option for series recordings (where the settings can be edited, under the context item "create timer" (if memory serves).

Like I said, i'll contact the addon author and see if there's any option for customization. Timer options, are not a major option for me, as I don't do much recording, but logic says (to me) any recording initiated that's not currently airing, ought to be editable.

Dan / Gib.

gibxxi commented 5 years ago

Cheers for the report.

Fixed now on git for Live TV. Auto fullscreen will work for radio and music only.

@mistervee

Looks like we have a regression issue with this. It's happening again.

Dan / Gib.

gibxxi commented 5 years ago

@mistervee

PVR logo artwork for TV and radio stations is being scaled to fit the display area on the Home / Main Menu screen...

https://imgur.com/5kDGnih

...but not when in the Music Visualization screen...

https://imgur.com/CNt0Rnv

Dan / Gib.

gibxxi commented 5 years ago

@mistervee

If watching Live TV in the background while setting up new (or pre-existing) video sources, and the context menu item "Set/Change Content" is invoked, using the arrow keys to move down across the the top two options; "This Directory Contains" / "Choose Information Provider" also sends those keystrokes to Kodi itself, and thus a channel change of the background playing PVR channel is the resulting action, as well as the selection moving down onto the top two options in the dialog box (one channel change per option / keystroke).

https://imgur.com/HNoJ7xk

Dan / Gib.

mistervee commented 5 years ago

@gibxxi

I can't replicate the issue.

Kodi issue i am not sure? May be a video of it in action?

Other thoughts, custom keymap issues or as i have mentioned before, do you get the same thing on Estuary?

Another note, i did see you posts in regards to other issues. Sorting the widgets and video info screens atm. Will get to them in time.

EDIT: Any weird non-graphical issue you find, please test in Estuary first, before you post. Just saves me time in replying and bug hunting. Really just want to focus in skin issues and not kodi issues, as i have no control of kodi bugs.

gibxxi commented 5 years ago

I'll see if I can conjure something up, but the only dedicated capture software I have is FRAPS, which is old as the hills.

I don't use custom keymaps, so I can rule that out. I'll get back to you on this one.

gibxxi commented 5 years ago

@mistervee

I can't replicate it either now. The curious thing was, that when I noticed this yesterday, upon selecting "Change Content" for a particular video source (I have 3 categories of video media for both Movies and TV Shows), the dialog box did not have any row show up as selected. One keystroke was nessecary for Madnox to "Acquire" focus on the dialog box, and a further 1 or 2 to then select one of the top two options. I was running Kodi in a non-fullscreen Window at the time (Only Windows taskbar visible behind). I was also controlling a remote system over AnyDesk Remote Desktop, so that may have a bearing on this.

Suffice to say, this morning, attempting the same action(s) via my desktop Kodi install, does not illicit the issue, either in Madnox or in Estuary. Sorry if I have wasted your time on this.

Dan / Gib.

EDIT: I figured it out; It's "Mouse / Touchscreen Support". With it enabled, moving the mouse outside the bounds of any active dialog box or window will return focus / control to Kodi core. So with a TV channel playing in the background, the cursor keys will then affect that (initially), and not the foreground dialog box. Disabling support for the mouse / touchscreen prevents the issue.

mistervee commented 4 years ago

DONE