Dialogs

[bartolomesoriano]

From @mistervee on April 26, 2017 2:35

DialogAddonSettings.xml DONE Mr.V DialogAudioDSPManager.xml Doesn't exist DialogBusy.xml DONE Mr.V DialogButtonMenu.xml DONE Mr.V DialogConfirm.xml DONE Mr.V DialogContextMenu.xml DONE meowmoo, Mr.V DialogDownloadProgress.xml for script.module.simple.downloader - cant find one plugin that uses this xml - i only get a popup when the download is complete REMOVED DialogExtendedProgressBar.xml DONE Mr.V DialogFavourites.xml DONE Mr.V, MAD (only one view type is this enough) DialogGameControllers.xml Doesn't exist DialogKeyboard.xml DONE Mr.V DialogMediaSource.xml DONE Mr.V. bartolomesoriano DialogNotification.xml DONE Mr.V DialogNumeric.xml DONE Mr.V
DialogSeekBar.xml
DialogSelect.xml DONE Mr.V DialogSettings.xml. DONE Mr.V, bartolomesoriano DialogSlider.xml
DialogSubtitles.xml bartolomesoriano will work on this DialogTextViewer.xml DONE bartolomesoriano, Mr.V DialogVolumeBar.xml DONE Mr.V DialogFullScreenInfo.xml

VideoOSD.xml Mr.V, bartolomesoriano, meowmoo ????? might need a var for the label, right side menu for 3d and dvd focus texture not quite right, pvr needed too. Might need info button? VidoesOSDBookMarks.xml Mr.V, bartolomesoriano, meowmoo - almost there MusicOSD.xml meowmoo almost there

Pointer.xml DONE Mr.V SmartPlaylistRule.xml DONE meowmoo, Mr. V SmartPlaylistEditor.xml DONEMr.V Filebrowser.xml DONE Mr.V

Copied from original issue: mistervee/skin.madnox.backup#4

[bartolomesoriano]

From @mistervee on April 26, 2017 22:28

@MadMikeDoc This would be the best place to start to get a feel for the re-code and $PARAM includes.

I would suggest to have a look at reworking DialogTextViewer.xml for starters and refer to; http://kodi.wiki/view/Skinning_Manual#DialogTextViewer.xml

This should be of some help https://github.com/mistervee/skin.madnox/wiki/$PARAM-Includes-and-Modularity

[bartolomesoriano]

@mistervee , thank you for this, it gives me a chance to learn some skinning. After reading the wiki page and looking at Includes_CommonObjects, in the include Dialog_Button_TopRight, you have two params, label and onclick. However, inside the include you use $PARAM[id]. Is this correct even though you didn't define an id param for that include? Pardon me if this is a dumb question that reflects my lack of skinning knowledge.

[bartolomesoriano]

From @mistervee on April 26, 2017 23:36

It will still work. You could even completely remove all the defined param at the top of the include. In that case you would not need the definition tags in the includes.

My preference is to define all the params in the include so you can copy and paste in the xml you want to use it in. Just makes life easy so you don't need to look through the include to find what $PARAM you have used.

[bartolomesoriano]

Got it, thanks @mistervee.

[bartolomesoriano]

From @mistervee on April 26, 2017 23:40

I think you have push rights so if you want to pick a dialog and have a go at updating it go right ahead and push to the repo. I can guide you along the way.

[bartolomesoriano]

Great! I will do that, thanks.

[bartolomesoriano]

@mistervee, I am working on DialogContextMenu. I want to create an include in Include_CommonObjects for a list for the menu, and then use that include in the dialog with item tags. Is there any list that you already did that you recommend to take as the basis? Also, I am thinking of having the icon that is shown with each of the menu options be part of the list itemlayout. Am I correct is supposing that I can set ListItem.Icon to the icon associated with each option?

[bartolomesoriano]

From @mistervee on May 12, 2017 1:59

@bartolomesoriano

Sorry didn't update the list. meow updated that a few days ago. And i have half done the shutdown menu.

Hoe you haven't done to much work on it.

[bartolomesoriano]

@mistervee, no worries! I will go back to the subtitles dialog. The question stands though, which list should I use as a basis for ones I create?

[bartolomesoriano]

From @mistervee on May 12, 2017 2:9

i am thinking the DialogAddonSettings.xml should work.

[bartolomesoriano]

@mistervee you haven't committed the latest changes yet?

[bartolomesoriano]

From @mistervee on May 12, 2017 3:50

Soon. still tidying up stuff. will be a rather large commit

[bartolomesoriano]

From @mistervee on May 14, 2017 6:52

@bartolomesoriano Done.

[bartolomesoriano]

Thanks!