mistic100 / Photo-Sphere-Viewer

A JavaScript library to display 360° sphere panoramas.
https://photo-sphere-viewer.js.org
MIT License
1.87k stars 675 forks source link

360-movies colors washed #970

Closed GeorgLegato closed 1 year ago

GeorgLegato commented 1 year ago

Describe the bug

I produce videos for the Photosphere viewer. In normal players, like VLC, mplayer, browsers etc. the videos are ok, regards the colors, saturation etc. Playing the 360-movie using the equi-video-adapter, it is losing saturation a lot: (left browser-video-canvas, right: Photosphere viewer) image

Here is the FFPROBE output of my video:

 Metadata:
    major_brand     : isom
    minor_version   : 512
    compatible_brands: isomiso2avc1mp41
    encoder         : Lavf58.29.100
  Duration: 00:00:02.00, start: 0.000000, bitrate: 7474 kb/s
  Stream #0:0[0x1](und): Video: h264 (High) (avc1 / 0x31637661), yuv420p(tv, bt709, progressive), 2496x1536, 7465 kb/s, 60 fps, 60 tbr, 15360 tbn (default)
    Metadata:
      handler_name    : VideoHandler
      vendor_id       : [0][0][0][0]

Actually ok, it follows the BT709 / sRGB html standard.

what I tried already:

Online demo URL

No response

Photo Sphere Viewer version

5.1.5

Plugins loaded

equie-movie

OS & browser

chrome, edge, firefox

Additional context

just for your information: I produce zomming with "my" stable-diffusion extension https://github.com/v8hid/infinite-zoom-automatic1111-webui

and the 360-viewer-integration comes from my repo: https://github.com/GeorgLegato/sd-webui-panorama-viewer

GeorgLegato commented 1 year ago

https://github.com/mistic100/Photo-Sphere-Viewer/assets/7210708/17c65957-346f-44ef-a36d-e402130a6b54

mistic100 commented 1 year ago

I do not get the same result, here is what it looks like on my machine on both Firefox and Chrome

Capture

By the way the library does not do any transformation to the video, it is a standard <video> element feed directly to Three.js
So I don't know what could be changed.

GeorgLegato commented 1 year ago

i have other issues due to dark theming in browsers ( or by the window manager like gnome) when displaying svg.... could it be some too clever dark theme routine is modifying video as well? i see my prob on ubuntu/chrome/ff and on win10/edge

but already good too know it is not an video encoding issue

i will try more browser/dark/light theme tests ... but why is a theme then touching the equi movie but not the plain video canvas? I checked in the dom if there are overlays, transparencies which could desaturate the canvas, haven't seen any suspicious yet

GeorgLegato commented 1 year ago

I do not get the same result, here is what it looks like on my machine on both Firefox and Chrome

Capture

By the way the library does not do any transformation to the video, it is a standard <video> element feed directly to Three.js

So I don't know what could be changed.

42 days ago the 360 video had correct colors, see in my video

https://www.reddit.com/r/aiArt/comments/12npyx4/preview_infinitezoom360panoramamovie_high_res/?utm_source=share&utm_medium=ios_app&utm_name=ioscss&utm_content=1&utm_term=1

the photosphere js is loaded via Githubissues.

  • Githubissues is a development platform for aggregating issues.