search

mistricky / codesnap.nvim

📸 Snapshot plugin with rich features that can make pretty code snapshots for Neovim
MIT License
483 stars 16 forks source link

Always whole lines showing, regardless of the selection #10

Closed marqmitk closed 3 months ago

marqmitk commented 4 months ago

In visual block and visual line mode, the screenshot shows the whole lines and in the last line up to the cursor, not what is actually selected.

2024-02-23-093959_hyprshot

2024-02-23-094024_hyprshot

mistricky commented 4 months ago

Hi @marqmitk, thx for your bug report and PRs again! normally code always shows line-by-line, as a code snapshot plugin, is block-visual features snapshot really necessary?

marqmitk commented 4 months ago

good point, thought the same thing already, only reason i would find it useful is for consistency, so if its not implemented i would add a notification that it doesn't work or just remove it from the modes that trigger the preview. but you are right that its not really useful for sharing code

mistricky commented 4 months ago

I think block-visual may not be for code snapshot, maybe we can add notification about visual block not work at document, and if more suitable scenario about visual block found, then reopen this issue and consider to implement it, how do you think?

marqmitk commented 4 months ago

good idea! removing it for now is the best option i think. but later for text documents for example it would be a nice feature