search

mistricky / codesnap.nvim

📸 Snapshot plugin with rich features that can make pretty code snapshots for Neovim
MIT License
483 stars 16 forks source link

support FreeBSD #58

Closed dch closed 2 months ago

dch commented 2 months ago

I did this in line with the existing code for simplicity

I think there may be simpler / cleaner ways to accommodate this overall approach but this seems a good start.

Testing was done with:

Build type: Release
LuaJIT 2.1.1699801871

snap

dch commented 2 months ago

If you plan to cross-build the rust libraries in CI or similar, here's output of uname etc, the code might need to be amended in that case.

# uname
FreeBSD

### now on x86_64
# uname -m
amd64

### now on aarch64
# uname -m
arm64
dch commented 2 months ago

NB the weird glyph is actually a light grey background >... visible whitespace. Not quite sure how to hide/fix that?

mistricky commented 2 months ago

Hi @dch, thx for this PR, if you wanna support FreeBSD, you also need to update the github actions config. But I don't wanna add too many cross-compilation target. I only have 2000 minutes per month usage time for GitHub actions, and the mac CI expensive more :(

Cross-compile is just an option which allow most users to use CodeSnap.nvim out of box, if your OS not in the cross-compilation list, you can still compile CodeSnap.nvim from source use make build_generator command.

mistricky commented 2 months ago

NB the weird glyph is actually a light grey background >... visible whitespace. Not quite sure how to hide/fix that?

Did you found the reproduce path? I can't reproduce this bug on my machine

mistricky commented 2 months ago

Hey @dch if you found reproduce path, you can open another issue to report it, this PR closed now.