mistrmochov / magiskWaydroid

Small and quick script, that puts finished magisk files to waydroid directory. Fully working Magisk Delta!!
GNU General Public License v3.0
24 stars 2 forks source link

Part of this script only works for systemd, add support for other init systems #1

Open blacklightpy opened 6 months ago

blacklightpy commented 6 months ago

For example, Void Linux uses runit, and the command is sudo sv stop/start waydroid-container.

Also my session is not booting now, even though I restarted the container..

mistrmochov commented 6 months ago

Thanks for mentioning, I will look into this

mistrmochov commented 6 months ago

Hey so I just fired up void linux in virtual machine and updated my script according the runit, but Waydroid doesn't boot after magisk is installed. I'm gonna try to do something about it. My guess is, that It's gonna be something kernel related like in Arch, because in Arch we need linux-xanmod-anbox so I'm gonna try to find something simmiliar. But before that, I'm not gonna update the script for runit, because It doesn't work. After someone or I will find a solution for that, script will be updated. Update: So I just got working linux-xanmod-anbox kernel on void linux and still the same issue, So I guess there might be a problem with runit or some configuration in void linux.

mistrmochov commented 6 months ago

Final update. So I find the cause of the issue. It's magisk files in adb folder. It booted fine when I deleted them. Then I installed magisk apk on waydroid and It prompted for additional installation and rebooted and created these files again. And unbootable again. Because these file are neccessary for magisk to work, There is nothing I can do about this unfortunately. I guess It is incompatible with runit or with Void Linux

blacklightpy commented 6 months ago

I don't see what runit has to do with it here.. All you do is restart the waydroid-container.service in systemd.

In runit that is sudo sv [start/stop/restart] waydroid-container.

It should be something else, although I don't see what.. did you try glibc or musl edition?

I'm on musl, although most distros are glibc-based.

mistrmochov commented 6 months ago

Well, but the problem doesn't have to anything with restarting the container. The problem is, that the waydroid on void linux is unbootable with magisk. But Im gonna keep digging.

mistrmochov commented 6 months ago

Greetings, I'm bringing another updates. So I just figured out, that voidlinux doesn't like busybox file in data/adb/magisk So my thoughts are, that voidlinux probably miss some general configuration out of the box. I tried to install busybox and mkinitcpio on void, but Waydroid was still unbootable

blacklightpy commented 6 months ago

Void uses dracut instead of mkinitcpio by default, could that be a reason?

https://docs.voidlinux.org/config/kernel.html#changing-the-default-initramfs-generator

One thing to note is if you used the musl version of Void, it doesn't work well with files compiled for glibc. Waydroid is compiled for glibc, but the busybox binary you used may not be.

blacklightpy commented 6 months ago

I hear that busybox is generally built against glibc unless it is from Alpine repos, etc.

I'm on musl too.

mistrmochov commented 6 months ago

No no I didn't download musl version. But yeah I think, there is pretty high chance, that It will be, because it's not using mkinitcpio

blacklightpy commented 6 months ago

You can switch to use mkinitcpio though.. it's explained in the page I linked.

mistrmochov commented 6 months ago

And you made it working? I fired up VM with void, just to try to make solution for you or for others, who have runit and voidlinux and update the script.

mistrmochov commented 6 months ago

Huh So I switched to mkinitcpio and regenerated linux and It still doesn't boot

blacklightpy commented 6 months ago

Nope I just made the observation..