search

mistval / jp-verb-deconjugator

Unconjugate conjugated Japanese verbs.
MIT License
23 stars 2 forks source link

add type declarations #4

Closed birdue closed 4 months ago

birdue commented 4 months ago

also fix two instances of const that should've been let

I didn't change anything else and the rest of the diff was generated solely because of prettier

mistval commented 4 months ago

Hi, nice, thanks for doing that!

mistval commented 4 months ago

Published to NPM as v1.1.0.

birdue commented 4 months ago

I just wanted to say, thank you for writing this great package! I've tried a few other packages that do the same thing but they all shoot for accuracy, which inevitably fails for special cases, not to mention situations where there are multiple valid "base forms" to begin with. This package takes a more comprehensive approach which can lead to redundancy, but sometimes this is a necessary tradeoff to obtain all valid results. Good job!

mistval commented 4 months ago

I appreciate your saying that =] I'd like to take another look at this project with fresh eyes when I get a chance. There's certainly plenty of room to improve still.