mistval / unofficial-jisho-api

Encapsulates the official Jisho.org API and also provides kanji, example, and stroke diagram search.
MIT License
139 stars 14 forks source link

Fix PhrasePageScrapeResult typedef #21

Closed h7x4 closed 4 years ago

h7x4 commented 4 years ago

There has been added a new interface to correct the otherForms property of a phrase scrape result.

I've noticed that the interface is quite similar to the JishoJapaneseWord from the API. There is a possibility to merge them together to a single interface JapaneseWord, but as it would probably break someones code and bump the project version to 3.0.0, I'll just leave it as a note.

mistval commented 4 years ago

Nice, thanks again 👍