NHK - On Demand Error still

Andulien commented 8 years ago

As I cannot reopen my previous issue, I am opening a new one. The issue regarding On Demand is still existent on my machine after your latest update. When clicking on On Demand, nothing happens and a message pops up to check the log for the error. Here is the log file:

Issue is still existing.

20:10:25 T:5072 NOTICE: Checking resolution 16 20:10:26 T:5072 NOTICE: Running database version Addons20 20:10:26 T:5072 NOTICE: Running database version ViewModes6 20:10:26 T:5072 NOTICE: Running database version Textures13 20:10:26 T:5072 NOTICE: Running database version MyMusic56 20:10:26 T:5072 NOTICE: Running database version MyVideos99 20:10:26 T:5072 NOTICE: Running database version TV29 20:10:26 T:5072 NOTICE: Running database version Epg11 20:10:26 T:5072 WARNING: JSONRPC: Could not parse type "Setting.Details.SettingList" 20:10:26 T:2900 NOTICE: PVRManager - starting up 20:10:26 T:5072 NOTICE: ActiveAE DSP - starting 20:10:26 T:5072 NOTICE: initialize done 20:10:26 T:5072 NOTICE: Running the application... 20:10:26 T:5072 NOTICE: starting zeroconf publishing 20:10:26 T:5072 NOTICE: WebServer: Started the webserver 20:10:26 T:5072 NOTICE: starting upnp client 20:10:26 T:1412 NOTICE: ES: Starting UDP Event server on 127.0.0.1:9777 20:10:26 T:1412 NOTICE: UDP: Listening on port 9777 20:10:29 T:4756 NOTICE: script.grab.fanart: Grab Fanart Service Started 20:10:30 T:3180 NOTICE: script.module.youtube.dl: youtube_dl core version: 2016.05.21.2 20:10:30 T:3180 NOTICE: version 4.6.1 started 20:10:31 T:1092 NOTICE: script.module.youtube.dl: youtube_dl core version: 2016.05.21.2 20:10:32 T:1092 NOTICE: Previous line repeats 1 times. 20:10:32 T:1092 NOTICE: version 4.6.1 started 20:10:33 T:1092 NOTICE: Previous line repeats 1 times. 20:10:33 T:1092 WARNING: Attempt to use invalid handle 5 20:10:33 T:1092 WARNING: Previous line repeats 29 times. 20:10:33 T:1092 NOTICE: finished 20:10:33 T:3180 WARNING: Attempt to use invalid handle 3 20:10:33 T:3180 WARNING: Previous line repeats 29 times. 20:10:33 T:3180 NOTICE: finished 20:10:34 T:4768 NOTICE: Previous line repeats 1 times. 20:10:34 T:4768 NOTICE: script.module.youtube.dl: youtube_dl core version: 2016.05.21.2 20:10:34 T:4768 NOTICE: version 4.6.1 started 20:10:34 T:4196 NOTICE: EPG::CEpgContainer::Start - EPG thread started 20:10:34 T:4768 WARNING: Attempt to use invalid handle 6 20:10:34 T:4768 WARNING: Previous line repeats 29 times. 20:10:34 T:4768 NOTICE: finished 20:10:42 T:1304 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: Error Contents: No JSON object could be decoded Traceback (most recent call last): File "C:\Users\MCramer\AppData\Roaming\Kodi\addons\plugin.video.bestofnhk\default.py", line 722, in IDX_VOD(url) File "C:\Users\MCramer\AppData\Roaming\Kodi\addons\plugin.video.bestofnhk\default.py", line 254, in IDX_VOD vod_json = json.load(req) File "C:\Program Files (x86)\Kodi\system\python\Lib\jsoninit.py", line 290, in load **kw) File "C:\Program Files (x86)\Kodi\system\python\Lib\jsoninit.py", line 338, in loads return _default_decoder.decode(s) File "C:\Program Files (x86)\Kodi\system\python\Lib\json\decoder.py", line 366, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "C:\Program Files (x86)\Kodi\system\python\Lib\json\decoder.py", line 384, in raw_decode raise ValueError("No JSON object could be decoded") ValueError: No JSON object could be decoded -->End of Python script error report<-- 20:10:42 T:5072 ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.video.bestofnhk/?mode=vod&name=NHK%20World%20On%20Demand&url=http%3a%2f%2fwww3.nhk.or.jp%2fnhkworld%2fen%2fvod%2fvod_episodes.xml 20:10:42 T:5072 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.bestofnhk/?mode=vod&name=NHK%20World%20On%20Demand&url=http%3a%2f%2fwww3.nhk.or.jp%2fnhkworld%2fen%2fvod%2fvod_episodes.xml) failed

Andulien commented 8 years ago

Solved the issue, it seems you have nowhere the url for VOD defined, needed for 253 in the default.py

To fix:

Please add in line 105: vod = 'http://api.nhk.or.jp/nhkworld/vodesdlist/v1/all/all/all.json?%s' % apikey

And change in 253 the "url" to "vod" to better distinguish it from other needs in your code for "url". I would also suggest to change in line 253 & 254 the "req" to "req_vod". Same counts for other occurences of the variable "req" as this could potentially lead to errors or confusions in the code.

See my current pull request.

Thanks and keep up the good work with the Addon :+1:

misty- commented 8 years ago

Hi Andulien,

I left a comment on your pull request. Please look at line 111 in the default.py. You will see the vod url is defined and it is the proper place. I use this add-on almost daily on either a Windows box or a Mac and have not had problems. I also test on a weekly basis on Android device to be sure it is running smoothly.

Python passes variables correctly to defined functions.

misty- / addons

NHK - On Demand Error still #5