mistydemeo / tigerbrew

Experimental fork of homebrew for PPC Macs on Tiger
Other
545 stars 130 forks source link

HOMEBREW_LEOPARD_64_BIT does not seem to have effect #63

Open ghost opened 11 years ago

ghost commented 11 years ago

I removed this flag from my profile, loaded a fresh shell and tried rebuilding my stuff to 32-bit (starting from scratch).

Funny that we should have the opposite problem now, but it's forcing 64 bit mode anyway. :)

mistydemeo commented 11 years ago

I haven't written the code for that yet. ;) It doesn't do anything yet.

ghost commented 11 years ago

Whoops. :-) When do you think that will happen?

PS I found a G5 we can use for testing. I'm just cleaning it up now. I also found a G3 iBook running 10.4, is that also of interest to put online for testing purposes?

mistydemeo commented 11 years ago

This should be enabled now as of 00b840341ac4e45c7fa101c181054f75674781a4. Can you test to make sure?

I altered the behaviour of MacOS.prefer_64_bit?; it now returns true on Snow Leopard and newer, always returns false on Tiger and older, and conditionally returns true on Leopard only when HOMEBREW_LEOPARD_64_BIT is set in the environment. When MacOS.prefer_64_bit? is false on G5, tigerbrew returns the CPU type in Hardware::CPU.family as :g5_32, which will set up CFLAGS for a 32-bit G5-optimized build.

As well, in 3f01a304c8a8d5c7adb4df7291a88eaf5f41e892, ld64 should always be enabled in every build on Leopard so long as it's installed. If that doesn't work, let me know!

mistydemeo commented 11 years ago

PS I found a G5 we can use for testing. I'm just cleaning it up now. I also found a G3 iBook running 10.4, is that also of interest to put online for testing purposes?

Could be useful! I know there's at least one G3 problem I've been trying to diagnose, but it's hard to do so remotely without access to hardware with that CPU. Thank you very much!

mistydemeo commented 11 years ago

Note to self: HOMEBREW_LEOPARD_64_BIT needs to be documented.

mistydemeo commented 11 years ago

Can you plesae post your brew --config so we can be sure it's active? From your other issues I'm concerned it's still setting your machine as :g5_32.

ghost commented 11 years ago

brew --config HOMEBREW_VERSION: 0.9.4 ORIGIN: https://github.com/mistydemeo/tigerbrew.git HEAD: 93d3313dec2bc0fc6056d0ab8e8d90ef008dc047 HOMEBREW_PREFIX: /usr/local HOMEBREW_CELLAR: /usr/local/Cellar CPU: single-core 64-bit g5 OS X: 10.5.8-Power Macintosh Xcode: 3.1.4 GCC-4.0: build 5493 GCC-4.2: build 5577 LLVM-GCC: build 2064 Clang: N/A X11: 2.1.6 => /usr/X11 System Ruby: 1.8.6 Perl: /usr/bin/perl Python: /usr/bin/python => /System/Library/Frameworks/Python.framework/Versions/2.5/bin/python2.5 Ruby: /Users/w/.rvm/bin/ruby

mistydemeo commented 11 years ago

OK, good. That settles that at least.

Can you post the brew --env foo for something that's building 32-bit? Say, brew --env cc65.

ghost commented 11 years ago

Is HOMEBREW_LEOPARD_64_BIT still being used, or is it phased out?

mistydemeo commented 11 years ago

Should be working. It won't be the default until it's working more reliably.

One of your recent build outputs showed that the correct 64-bit flags were being passed, so I think it's functioning.

ghost commented 11 years ago

Oh but the flag isn't set on my system! I had commented it out.

ghost commented 11 years ago

Confirmed. This flag is not set but my system is defaulting to building 64-bit binaries.

mistydemeo commented 11 years ago

Aha, MacOS.prefer_64_bit? went awry in a recent merge. I'll get that fixed.

ghost commented 11 years ago

Unfortunately this did not seem to fix it. Git for example is still trying to build 64-bit

ghost commented 11 years ago

I suggest creating a PPC64 label for these issues.