search

mit-cml / appinventor-sources

MIT App Inventor Public Open Source
http://appinventor.mit.edu/appinventor-sources/
Apache License 2.0
1.45k stars 2.04k forks source link

German translations for web-component are the same #2202

Open mikebarkmin opened 4 years ago

mikebarkmin commented 4 years ago

Describe the bug

The put and post-block are translated exactly the same in German:

Post-Block: https://github.com/mit-cml/appinventor-sources/blob/c9c961e1895c44872bb7e0b2830de6593c6afc99/appinventor/appengine/src/com/google/appinventor/client/OdeMessages_de.properties#L345-L347

Put-Block: https://github.com/mit-cml/appinventor-sources/blob/c9c961e1895c44872bb7e0b2830de6593c6afc99/appinventor/appengine/src/com/google/appinventor/client/OdeMessages_de.properties#L355-L357

Expected behavior

Maybe it is better to not translate the HTTP method.

PostFileMethods = PostDatei
PostTextMethods = PostText
PostTextWithEncodingMethods = PostTextMitVerschlüsselung

PutFileMethods = PutDatei
PutTextMethods = PutText
PutTextWithEncodingMethods = PutTextMitVerschluesselung

Or probably better, the literal translation of Put -> Setzen kann be used to differentiate between them.

PostFileMethods = SendeDatei
PostTextMethods = SendeText
PostTextWithEncodingMethods = SendeTextMitVerschlüsselung

PutFileMethods = SetzeDatei
PutTextMethods = SetzeText
PutTextWithEncodingMethods = SetzeTextMitVerschluesselung

Steps to reproduce

  1. Change language to German
  2. Drag a web component in the designer.
  3. Switch to the block editor
  4. Try to figure out which block can be used for a POST and which for a PUT request.
mikebarkmin commented 4 years ago

I also want to add that PostTextWithEncodingMethods would be better translated to SendeTextMitKodierung. Verschluesselung can be translated to Encryption, which does not suit the block.

mikebarkmin commented 4 years ago

I can create a pull-request, if these changes are ok for you.

ewpatton commented 4 years ago

@mikebarkmin We're managing our translations through https://weblate.appinventor.mit.edu. You should create an account there and then ping @SusanRatiLane so she can grant you access to the German translation.

mikebarkmin commented 4 years ago

@SusanRatiLane I have created an account (mikebarkmin). Can you please grant me permission?

ewpatton commented 1 year ago

@mikebarkmin @SusanRatiLane Was this ever resolved? These changes seem fairly straightforward to implement.