search

mit-cml / appinventor-sources

MIT App Inventor Public Open Source
http://appinventor.mit.edu/appinventor-sources/
Apache License 2.0
1.49k stars 2.07k forks source link

New ListView layout: image, main text, detail text stacked vertically #2595

Open SusanRatiLane opened 3 years ago

SusanRatiLane commented 3 years ago

Describe the desired feature

ListView should have a layout that is image, main text, detail text stacked vertically.

A layout where the image has nothing beside it allow the image to be scaled much larger. Most horizontal (swipe left/right) layouts make use of large pictures, e.g. music album covers or people's faces. ListView can be oriented horizontally, but that feature currently isn't very usable.

Yash621 commented 2 years ago

@SusanRatiLane can i work on this ?

devarsh-mavani-19 commented 2 years ago

@SusanRatiLane are you asking for this type of layout? Screenshot from 2022-02-07 12-03-53

SusanRatiLane commented 2 years ago

@devarsh-mavani-19 Yes. That exactly the idea. We have a horizontal swipe orientation for ListView but no layouts that would make sense to use with it. The logical thing is a picture that supports an image that can be sized large.

devarsh-mavani-19 commented 2 years ago

@SusanRatiLane ohk got it. if you haven't already started on this can i work on it?

Yash621 commented 2 years ago

@devarsh-mavani-19 lets work on it together ?

SusanRatiLane commented 2 years ago

I think it's probably too much for you both to try to coordinate working on it together. Since @Yash621 asked first, I'm assigning to him.

You're thinking in good directions, @devarsh-mavani-19 . I encourage you to look for another item.

Yash621 commented 2 years ago

@SusanRatiLane thank you ,I will raise a PR for this shortly.

devarsh-mavani-19 commented 2 years ago

@SusanRatiLane no worries I will work on something else thanks :)

Yash621 commented 2 years ago

@SusanRatiLane can you guide me in which files ,I should work on for this ?

preetvadaliya commented 2 years ago

Probably you need to look at ListView.java ListAdapterWithRecyclerView.java which are in component/ folder under com.google.appinventor.components.runtime package.

Yash621 commented 2 years ago

@preetvadaliya I got what ListView.java is doing ,can you explain what ListAdapterWithRecyclerView.java functionality is ?

preetvadaliya commented 2 years ago

@Yash621 I have one question for you, are you familiar with App Inventor source? Because first you asked in which files you need to look and now you are asking about functionality.

I suggest you to explore more in App Inventor source.

devarsh-mavani-19 commented 2 years ago

@Yash621 you haven't posted in a while. So just in case you are not working on it, I think I can solve this issue.

sachinrao8312 commented 1 year ago

It is still open can you reassign it to me?