Notifier DismissProgressDialog closes all dialogs on iOS

mit-cml / appinventor-sources

MIT App Inventor Public Open Source

http://appinventor.mit.edu/appinventor-sources/

Apache License 2.0

1.5k stars 2.08k forks source link

Notifier DismissProgressDialog closes all dialogs on iOS #3213

Open ewpatton opened 3 months ago

ewpatton commented 3 months ago

Describe the bug

From the forum: Using the DismissProgressDialog block will dismiss dialogs of types other than the progress dialog.

Affects

[ ] Designer
[ ] Blocks editor
[ ] Projects Explorer
[x] Companion
[ ] Compiled apps
[ ] Buildserver
[ ] Debugging
[ ] Other... (please describe)

Expected behavior

The DismissProgressDialog block should only close an active progress dialog.

Steps to reproduce

TBD

SusanRatiLane commented 3 months ago

@ewpatton I pulled down the test app on the community thread linked in the issue, and this branch does not seem to affect the user's example. Ferran_SIMON's app opens a progress dialog and a choose dialog at the same time. They appear on top of each other in both Android and iOS, with whichever dialog was created last on top.

In Android, if you dismiss one dialog, you see the second one underneath. In iOS, if you dismiss one dialog, they both go away.

This may not be the same as the issue discussed by the power users.

ewpatton commented 3 months ago

I think the challenge of handling multiple notifier presentations is a separate issue that will need to be addressed. This PR is specifically addressing the semantics around DismissProgressDialog.