Closed laurensvalk closed 9 months ago
I don't like the idea of having both boolean and number type for config at the same time, we might go for TypeScript later, just like what Blockly is having.
So I added a new weight
option there. Fixes available in #26
Sure. Sounds good to me, thanks for looking into this so quickly!
(For what it's worth, a boolean | number
type in Typescript is not uncommon.)
For what it's worth, a boolean | number type in Typescript is not uncommon.
At least it's kind of wired, anyway, I also don't want to break the current API by changing hideIcon
to showIcon
Confirmed with #26 that placement can now be selected:
as well as omitted
The icon seems to still take up space even when it is disabled:
hideicon: false
hideIcon: true
:And the weight is also hardcoded.
Possible API suggestion:
showIcon: false
: don't show at all, and don't take space.showIcon: true
: show in default weight (3)showIcon: someNumber
liketrue
, but weight set to given number.