mit-crpg / OpenMOC

A method of characteristics code for nuclear reactor physics calculations.
https://mit-crpg.github.io/OpenMOC/
Other
148 stars 83 forks source link

CMFD initialization should be just prior to track generation #170

Closed samuelshaner closed 9 years ago

samuelshaner commented 9 years ago

Currently the CMFD object is initialized in Geometry::initializeFlatSourceRegions(), but after this method is called, the user has the ability to change the boundary conditions. A change of the boundary conditions after Geometry::initializeFlatSourceRegions(), but prior to TrackGenerator::generateTracks() is called would result in a mismatch in the BCs in the MOC and CMFD problems. To fix this issue, the Geometry::initializeCmfd() method should be called within TrackGenerator::generateTracks() (or one of the methods called by this method) instead of in Geometry::initializeFlatSourceRegions().

wbinventor commented 9 years ago

Fixed in #172.