search

mit-crpg / OpenMOC

A method of characteristics code for nuclear reactor physics calculations.
https://mit-crpg.github.io/OpenMOC/
Other
148 stars 83 forks source link

Optional Arguments not Optional for CPUSolver and ThreadPrivateSolver #50

Closed nathangibson14 closed 10 years ago

nathangibson14 commented 10 years ago

ThreadPrivateSolver and CPUSolver have optional Geometry and TrackGenerator arguments in the constructor (default to NULL), but OpenMOC seg faults if Geometry and TrackGenerator objects aren't supplied.

wbinventor commented 10 years ago

This issue was created by improper instantiation of the Cmfd object in the Solver/CPUSolver/ThreadPrivateSolver constructors. The most recent commit now encapsulates all Cmfd initialization in the "initializeCmfd()" method which is called at the beginning of source iteration (i.e., the "convergeSource()" method).

Fixed in commit (master): c1afe59f83b509f6fea3b890f9dc48c280250ebd