search

mit-crpg / OpenMOC

A method of characteristics code for nuclear reactor physics calculations.
https://mit-crpg.github.io/OpenMOC/
Other
146 stars 82 forks source link

Scattering matrix input #94

Open nathangibson14 opened 10 years ago

nathangibson14 commented 10 years ago

The scattering matrix input could use a bit of work. It'd be nice to read in row-major order, which would be a little more Pythonic and avoid the need to transpose the matrix inside the code.

Similar to the inline function for getting scattering cross sections by group, logic for how the scattering matrix is stored could be condensed for the setters as well. Perhaps a macro for the scattering matrix can be used for both setters and the revamped getters?

wbinventor commented 10 years ago

I agree that this is and important issue that needs addressing to make the code consistent and intuitive. Since this is something you've looked at more than anyone recently, is it something you can take on? Perhaps we should aim to have this included in the next release which we're aiming to release at the end of August.

Also, I'm glad that I'm not the only one in CRPG who uses the word "Pythonic" anymore. Perhaps if we keep using it on here we will make it credible enough to use in our PhD theses one day.

wbinventor commented 10 years ago

PrezNattyGibbs - any chance this can be completed in the next few weeks? We had targeted a v0.1.3 release at the end of August and it would be nice to include this change.

nathangibson14 commented 10 years ago

This one isn't overly high on my priority list right now. If my other work goes well, I can try to get it out in the next few weeks. But no guarantees. I don't think it's overly important for the next release, but if you disagree, maybe I can be convinced to move it up higher on my list.

On 08/17/2014 06:52 PM, Will Boyd wrote:

PrezNattyGibbs - any chance this can be completed in the next few weeks? We had targeted a v0.1.3 release at the end of August and it would be nice to include this change.

— Reply to this email directly or view it on GitHub https://github.com/mit-crpg/OpenMOC/issues/94#issuecomment-52438180.

wbinventor commented 10 years ago

We can wait on this one. Just trying to clean out our issues list a little bit!

wbinventor commented 9 years ago

@PrezNattyGibbs - just reviewing our issues list for an "end-of-the-year" cleanup. Can you package up a PR for this issue during January?