search

mit-crpg / WMP_Library

Windowed Multipole Library
MIT License
11 stars 13 forks source link

Meaning of 'version' #4

Closed paulromano closed 6 years ago

paulromano commented 6 years ago

@liangjg Right now, OpenMC checks the version of the multipole library and aborts if it does not match what it expects. Going forward, it seems reasonable to expect a new multipole library (perhaps based on a different data library) that still has the same file format. Should version in the HDF5 file be interpreted as "version of the file format" or "version of the data itself"? If the latter, then we shouldn't be aborting OpenMC based on whatever appears.

liangjg commented 6 years ago

@paulromano well, I guess it is preferable to interpret the version as version of the file format, just the same as other io_file formats used in openmc. This PR tries to update OpenMC to use the newer library.

paulromano commented 6 years ago

Perfect, thanks for the accompanying PR!