search

mit-crpg / opendeplete

A depletion framework for OpenMC
MIT License
15 stars 5 forks source link

Fix for OpenMC natural elements #32

Closed wbinventor closed 7 years ago

wbinventor commented 7 years ago

This is my stab at trying to fix the support for natural elements as described in #31. I don't really know what I'm doing here, so feel free to close this and fix it in a better way @cjosey.

wbinventor commented 7 years ago

This doesn't appear to be quite right since the eigenvalues for the first OpenMC run are much lower than they should be. Something must be up with the density conversion. I don't have any more time to work on this today, but perhaps tomorrow.

wbinventor commented 7 years ago

I think I fixed the issue by now extracting the atom densities for each nuclide (whether explicitly specified by the user or expanded under-the-hood for a natural element) from each openmc.Material object.

cjosey commented 7 years ago

Not all tests pass. Since burnable was changed to depletable, lines 341 and 353 in tests/example_geometry.py are out of date. Changing those, it passes all tests. I also am pretty sure it works correctly.

If you see any more issues like these, let me know. I'm very unfamiliar with the OpenMC API. I basically figured out the minimum required to get my code running and left it at that.

wbinventor commented 7 years ago

Ok I just changed "tests/example_geometry.py" to use `depletable.

cjosey commented 7 years ago

All good. Thanks for the fix!