search

mit-crpg / opendeplete

A depletion framework for OpenMC
MIT License
15 stars 5 forks source link

Allow branching ratios on reactions #37

Closed paulromano closed 7 years ago

paulromano commented 7 years ago

This pull request makes a fairly simple change in the Nuclide class, grouping together attributes related to decay modes and attributes related to reactions into namedtuples. In addition, reactions are allowed to have branching ratios, which would enable us to specify energy-independent capture branching ratios if that is the route we decide to go.

paulromano commented 7 years ago

Testing at its best -- your test_form_matrix helped me realize there was a bug. Reactions were getting doubled counted as losses in form_matrix. Thanks for the suggestion! I'm about to push a commit that will fix that and the other minor issues you commented on.

cjosey commented 7 years ago

It all looks good to me.