search

mit-crpg / opendeplete

A depletion framework for OpenMC
MIT License
15 stars 5 forks source link

Fix potential bug in Concentrations and ReactionRates #4

Closed paulromano closed 7 years ago

paulromano commented 7 years ago

It appears there is a potential bug in __getitem__ and __setitem__ for the Concentrations and ReactionRates classes; namely, if an integer is used for the nuclide index directly, it would actually receive the value for the cell.

cjosey commented 7 years ago

Good catch. I never caught that one as I always used the string indexing.
In fact, these whole classes seem a bit awkward. I might want to reconsider them when I get the chance.