search

mit-dci / lit

Lightning Network node software
MIT License
551 stars 119 forks source link

Add stopEx bool to CheckHelpCommand #250

Closed Varunram closed 6 years ago

Varunram commented 6 years ago

Earlier, we didn't have a way whether we should stop execution, instead we relied on the code that follow to do that for us. But this caused side effects like that in #231, which should now be solved with the introduction of this bool.

adiabat commented 6 years ago

Can you change it from error, bool to bool, error? Other functions we use have errors at the end. Also, can you document in a function definition comment what the bool means. thanks

Varunram commented 6 years ago

retest this please

adiabat commented 6 years ago

Looks good, thanks!