search

mit-dci / lit

Lightning Network node software
MIT License
551 stars 119 forks source link

Python tests don't work with bitcoind v0.16.99 #286

Closed Varunram closed 6 years ago

Varunram commented 6 years ago

As of commit d792e47421fcb9ce3b381c1e6d8902777ae3f9f3, the python tests don't start bitcoind as they're supposed to:

{'result': None, 'error': {'code': -32601, 'message': 'getinfo\n\nThis call was removed in version 0.16.0. Use the appropriate fields from:\n- getblockchaininfo: blocks, difficulty, chain\n- getnetworkinfo: version, protocolversion, timeoffset, connections, proxy, relayfee, warnings\n- getwalletinfo: balance, keypoololdest, keypoolsize, paytxfee, unlocked_until, walletversion\n\nbitcoin-cli has the option -getinfo to collect and format these in the old format.'}, 'id': '5195'}

Will put in a PR with fixes (and maybe close more bugs!).

Varunram commented 6 years ago

Fixed in https://github.com/mit-dci/lit/pull/263/commits/93163c20a6cbb64dcb0792ce3ab9187766ad8168, will close issue after PR is merged

delbonis commented 6 years ago

My new test framework also works with 0.16.