search

mit-dci / lit

Lightning Network node software
MIT License
551 stars 119 forks source link

Added missing AcceptOrDecline argument #317

Closed navybluesilver closed 6 years ago

navybluesilver commented 6 years ago

Contracts are always being declined when using the accept command. This is because the AcceptOrDecline argument is missing.

dci-jenkins commented 6 years ago

Can one of the admins verify this patch?

Varunram commented 6 years ago

retest this please

Varunram commented 6 years ago

I think this is due to the many rebases we’ve had, thanks!

delbonis commented 6 years ago

Yeah maybe we should consider writing tests for lit-af itself?

And the reason the argument is named aor is because it referred to "Accept or Reject" in other places, perhaps we should rename things to be more internally-consistent.

Varunram commented 6 years ago

This is actually because we didn't follow set standards for merging of PRs. Please refer to my comment at #319.

navybluesilver commented 6 years ago

Sorry for the dirty commits related to "delete contract" logic. Forgot that this would be added to this PR automatically.